Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature idea - provisioning registrations #210

Open
variable opened this issue Mar 30, 2023 · 4 comments
Open

Feature idea - provisioning registrations #210

variable opened this issue Mar 30, 2023 · 4 comments
Labels
enhancement New feature or request

Comments

@variable
Copy link
Contributor

variable commented Mar 30, 2023

I have a feature request from my workplace to add an approval step for self-registering keys. Currently when someone registers a key, it can be authenticated immediately, the Authenticator model doesn't have a status field to disable the key.

Is this something I can implement and be included into this package?

@tpazderka
Copy link
Contributor

This can be currently (somewhat) achieved by disabling self-registration and using an admin view to add Authenticator to selected users.

As for the proposed change, I am not opposed to it as long as it is an opt-in.

@ziima @stinovlas your thought?

@tpazderka tpazderka added the enhancement New feature or request label Mar 30, 2023
@ziima
Copy link
Member

ziima commented Mar 30, 2023

Sounds reasonable

@stinovlas
Copy link
Member

I think this might prove useful in our workplace as well. Being able to disable authenticator without removing it sound like a good feature anyway =o).

@variable
Copy link
Contributor Author

This can be currently (somewhat) achieved by disabling self-registration and using an admin view to add Authenticator to selected users.

As for the proposed change, I am not opposed to it as long as it is an opt-in.

@ziima @stinovlas your thought?

Yeah this is what we have done so far, I have disabled self-registration but work is floating an idea to re-enable it again with approval step.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants