Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved dependency from pydantic to pydantic-settings #862

Merged
merged 1 commit into from
Jul 2, 2023

Conversation

infohash
Copy link
Contributor

@infohash infohash commented Jul 2, 2023

BaseSettings have been moved to pydantic-settings package under the same maintainer. As Pyoidc is using BaseSettings only in oic.utils.settings, we can change the dependency without any problem.

@schlenk
Copy link
Collaborator

schlenk commented Jul 2, 2023

Seems autodoc-pydantic isn't fit for the new v2 api yet either:
mansenfranzen/autodoc_pydantic#146

Your change is okay, so I'm merging this, to have working code.
The docs will hopefully fix themselves once autodoc_pydantic gets updated.

@schlenk schlenk merged commit 35c5afa into CZ-NIC:master Jul 2, 2023
0 of 5 checks passed
@infohash infohash deleted the fix/move-to-pydantic-settings branch July 3, 2023 10:25
@mansenfranzen
Copy link

@infohash @schlenk You can now test the new autodoc_pydantic version supporting pydantic v2 via pip install autodoc_pydantic==2.0.0. The dev docs already showcase v2 support (see here). Migration guide is available here.

Any feedback is more than appreciated. The current autodoc_pydantic version 2.0.0 on pypi remains yanked for one week until final release.

@schlenk
Copy link
Collaborator

schlenk commented Jul 25, 2023

Thanks for the fix @mansenfranzen . I tried it in a branch (#863) and it seems to fix the issue with the documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants