Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Italian translation #60

Merged
merged 9 commits into from
Oct 17, 2023
Merged

Conversation

quazar-omega
Copy link
Contributor

Hello!
I'd like to add Italian translations to this project, are there other files I need to touch to finalize the PR?

@vnepogodin
Copy link
Member

Hey @quazar-omega

Many thanks for contribution!

All in all looks good.

You need to also add "Italian" here after "German" lang(https://github.com/CachyOS/CachyOS-Welcome/blob/develop/ui/cachyos-hello.glade#L287).

Also if you want to translate "pages":

  • create folder "pages/it"
  • copy files from "pages/en" to "pages/it"
  • then translate

"involved", "readme" are less likely to change anytime
"release" changes with every release

Best regards

@NextWork123 NextWork123 self-requested a review October 11, 2023 15:49
i18n/it/cachyos_hello.ftl Outdated Show resolved Hide resolved
i18n/it/cachyos_hello.ftl Outdated Show resolved Hide resolved
i18n/it/cachyos_hello.ftl Outdated Show resolved Hide resolved
i18n/it/cachyos_hello.ftl Outdated Show resolved Hide resolved
@quazar-omega
Copy link
Contributor Author

@vnepogodin Glad to be of help!
I'll look into the other files as soon as possible :)

Copy link
Member

@NextWork123 NextWork123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing, now is perfect!

Waiting you gonna finish all the translation at 100%

@quazar-omega
Copy link
Contributor Author

You got it!
I'll see when I can translate the rest of the files

Formatted the <item id="it">Italian</item> it wasn't aligned with other items
@quazar-omega
Copy link
Contributor Author

Oops, thanks for that 😅

@NextWork123
Copy link
Member

Oops, thanks for that 😅

Np, i will stay review all xD

because i'm the only member from italy xD

@quazar-omega
Copy link
Contributor Author

Well, hey, ci si aiuta fra connazionali! ;)

@NextWork123
Copy link
Member

Well, hey, ci si aiuta fra connazionali! ;)

Ohoh, perfetto!

@NextWork123
Copy link
Member

@vnepogodin thanks for reviewed my commit and fixed again <3

@NextWork123 NextWork123 marked this pull request as ready for review October 13, 2023 12:30
@NextWork123
Copy link
Member

@quazar-omega Hello, wanted to know if is all good on my commit if you have some suggestion or other.

@quazar-omega
Copy link
Contributor Author

Hey! Sorry for the late response, was busy these last few days.

I'll be looking at them and proofread between today and tomorrow.
First file is looking great with some really minor nitpicky corrections, I'll see the rest tomorrow

@NextWork123
Copy link
Member

Hey! Sorry for the late response, was busy these last few days.

I'll be looking at them and proofread between today and tomorrow. First file is looking great with some really minor nitpicky corrections, I'll see the rest tomorrow

Ok!, i will wait for your response

Copy link
Member

@NextWork123 NextWork123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the correction seem all fine!

@quazar-omega
Copy link
Contributor Author

Yes the translation was on point, good job!

What about the dashes in the list changed to space indentation btw?

@NextWork123
Copy link
Member

Yes the translation was on point, good job!

What about the dashes in the list changed to space indentation btw?

Yeah seem all good you need to change other? if is all good too for you i gonna merge

@quazar-omega
Copy link
Contributor Author

Yes, you can go ahead!

@NextWork123 NextWork123 merged commit 2ef169e into CachyOS:develop Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants