Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the SINE_TABLE array in MathHelper #567

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Remove the SINE_TABLE array in MathHelper #567

wants to merge 2 commits into from
+16 −0

Conversation

Colonel-Sandvich
Copy link

@Colonel-Sandvich Colonel-Sandvich commented Oct 4, 2024 •
edited
Loading

Closes #381

2No2Name
2No2Name reviewed Oct 4, 2024
View reviewed changes
Copy link
Member

@2No2Name 2No2Name left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR is fine, the concerns already mentioned in the issue are mod compatibility. I don't expect this change to have any measurable effect on performance.

src/main/java/me/jellysquid/mods/lithium/mixin/math/sine_lut/MixinMathHelper.java Outdated Show resolved Hide resolved
@Colonel-Sandvich Colonel-Sandvich marked this pull request as ready for review October 4, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@2No2Name 2No2Name 2No2Name approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove the SINE_TABLE array in MathHelper
2 participants
@Colonel-Sandvich @2No2Name