Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DIG-1803, DIG-1810: query fixes #55

Merged
merged 4 commits into from
Oct 18, 2024
Merged

DIG-1803, DIG-1810: query fixes #55

merged 4 commits into from
Oct 18, 2024

Conversation

daisieh
Copy link
Member

@daisieh daisieh commented Oct 18, 2024

  • Searches should use the default giant page size
  • Discovery query needed its parameters updated to latest: add drug_name (systemic_therapy_drug_name)

I'm pretty sure that systemic_therapy and systemic_therapy_type are not used for this endpoint, but maybe I'm wrong.

@daisieh daisieh requested a review from OrdiNeu October 18, 2024 00:51
@mshadbolt
Copy link
Contributor

Did a quick test and the filtering seems to be working as expected from the front end

Copy link
Collaborator

@OrdiNeu OrdiNeu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just had to rebase so the code looked clearer but it all looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants