Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

50 move apply state to map builder #56

Conversation

Pewillia
Copy link
Member

@Pewillia Pewillia commented Nov 6, 2024

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # 50

Type of change

  • [ X] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [X ]mentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

(https://pewillia.github.io/geoview-demo/?config=01-basemap-LCC-TLS.json)

Checklist:

  • [X ] I have build (npm run build) and deploy (npm run deploy) my PR
  • [ X] I have connected the issues(s) to this PR
  • [ X] My code follows the style guidelines of this project
  • [ X] I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • [ X] My changes generate no new warnings
  • I have created new issue(s) related to the outcome of this PR is needed
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@Pewillia Pewillia self-assigned this Nov 7, 2024
@jolevesq jolevesq merged commit 5543a72 into Canadian-Geospatial-Platform:develop Nov 7, 2024
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants