From 520267da964cb33ef3de31dbe1c6b3998af5d31e Mon Sep 17 00:00:00 2001 From: Bryan Weber Date: Fri, 2 Aug 2024 16:47:29 -0400 Subject: [PATCH] [CI] Pin upload-artifact when uploading symlinks Version 4.3.5 broke uploading symlinks as artifacts. Reverting to 4.3.4 should resolve this until the error is fixed. --- .github/workflows/main.yml | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index bbe2e30371..f264faa231 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -102,7 +102,9 @@ jobs: python3 `which scons` build env_vars=all -j4 debug=n --debug=time \ system_fmt=y cc_flags=-D_GLIBCXX_ASSERTIONS - name: Upload shared library - uses: actions/upload-artifact@v4 + # Pin to 4.3.4 to resolve errors around only uploading symlinks. + # See https://github.com/actions/upload-artifact/issues/589 + uses: actions/upload-artifact@v4.3.4 if: matrix.python-version == '3.11' with: path: build/lib/libcantera_shared.so @@ -205,7 +207,9 @@ jobs: run: scons build env_vars=all -j3 debug=n --debug=time boost_inc_dir=${BOOST_INC_DIR} ${{ matrix.extra-build-args }} - name: Upload shared library - uses: actions/upload-artifact@v4 + # Pin to 4.3.4 to resolve errors around only uploading symlinks. + # See https://github.com/actions/upload-artifact/issues/589 + uses: actions/upload-artifact@v4.3.4 if: matrix.python-version == '3.11' && matrix.macos-version == 'macos-12' with: path: build/lib/libcantera_shared.dylib @@ -606,7 +610,9 @@ jobs: --debug=time -j4 shell: pwsh - name: Upload shared library - uses: actions/upload-artifact@v4 + # Pin to 4.3.4 to resolve errors around only uploading symlinks. + # See https://github.com/actions/upload-artifact/issues/589 + uses: actions/upload-artifact@v4.3.4 if: matrix.python-version == '3.11' with: path: build/lib/cantera_shared.dll