Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Counterflow Flame control #1622

Merged
merged 22 commits into from
Jun 21, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
14f8b8c
two-point flame control c++ additions
wandadars Sep 15, 2023
a2d109e
python interface additions
wandadars Sep 22, 2023
01ff36a
prevent refinement from shifting two-point control points
wandadars Sep 22, 2023
96ccb32
small formatting changes & comments
wandadars Sep 29, 2023
a1c71e5
zLeft and zRight outputs added for assessing two point control. Extra…
wandadars Oct 3, 2023
1fd2c25
added comments, fixed incorrect bc, other minor adjustments to two-po…
wandadars Jan 18, 2024
2c254a0
python unit test for two-point control
wandadars Apr 11, 2024
af9bf1d
updated comments for two-point control methods
wandadars Apr 12, 2024
1ae0032
[Test] Reduce pruning threshold to prevent oscillations
speth Apr 15, 2024
f7faff4
added a documentation section and an example
wandadars Apr 24, 2024
81b7eeb
[1D] Avoid output of unused solution components
speth Jun 2, 2024
15e8efc
Fix two-point functions with missing return values
speth Jun 2, 2024
d9f6124
updated governing equations section with more details on two-point me…
wandadars Jun 13, 2024
ee3b077
updated svg diagram to remove whitespace
wandadars Jun 13, 2024
f0b4900
doxygen comment updates & exceptions added for two-point method
wandadars Jun 13, 2024
aee2e26
updates to docstrings, code logic, and tests for two-point control
wandadars Jun 13, 2024
354fb02
added tests for two-point control method, not working for some
wandadars Jun 14, 2024
cbbf23a
improved comments for control point picking, added more tests, update…
wandadars Jun 17, 2024
9c29512
formatting changes & documentation/samples tweaks
wandadars Jun 19, 2024
5501ae5
fixed whitespace errors
wandadars Jun 19, 2024
cf9482d
[1D] Be more consistent about setting diag=0
speth Jun 21, 2024
a52f661
[1D] Update formatting related to two point flame control
speth Jun 21, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions doc/doxygen/cantera.bib
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,16 @@ @article{harvie1980
doi = {10.1016/0016-7037(80)90287-2},
pages = {981--997},
year = {1980}}
@article{huo2014,
author = {H.~Huo and X.~Wang and V.~Yang},
journal = {Combustion and Flame},
volume = {161},
title = {A general study of counterflow diffusion flames at subcritical and
supercritical conditions: Oxygen/hydrogen mixtures},
pages = {3040-3050},
url = {https://doi.org/10.1016/j.combustflame.2014.06.005},
doi = {10.1016/j.combustflame.2014.06.005},
year = {2014}}
@article{johnson1992,
author = {J.~W.~Johnson and E.~H.~Oelkers and H.~C.~Helgeson},
title = {{SUPCRT92}: {A} software package for calculating the standard molal
Expand Down Expand Up @@ -304,6 +314,16 @@ @article{niemeyer2017
url = {https://dx.doi.org/10.1016/j.cpc.2017.02.004},
volume = {21},
year = {2017}}
@article{nishioka1996,
author = {M.~Nishioka and C.K.~Law and T.~Takeno},
title = {A Flame-Controlling Continuation Method for Generating S-Curve
Responses with Detailed Chemistry},
journal = {Combustion and Flame},
volume = {104},
pages = {328-342},
url = {https://doi.org/10.1016/0010-2180(95)00132-8},
doi = {10.1016/0010-2180(95)00132-8},
year = {1996}}
@article{pedersen1993,
author = {T.~Pedersen and R.~.C.~Brown},
title = {Simulation of electric field effects in premixed methane flames},
Expand Down
330 changes: 330 additions & 0 deletions doc/sphinx/_static/images/two_point_control_diagram.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Loading