-
-
Notifications
You must be signed in to change notification settings - Fork 355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Counterflow Flame control #1622
Merged
Merged
Changes from 18 commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
14f8b8c
two-point flame control c++ additions
wandadars a2d109e
python interface additions
wandadars 01ff36a
prevent refinement from shifting two-point control points
wandadars 96ccb32
small formatting changes & comments
wandadars a1c71e5
zLeft and zRight outputs added for assessing two point control. Extra…
wandadars 1fd2c25
added comments, fixed incorrect bc, other minor adjustments to two-po…
wandadars 2c254a0
python unit test for two-point control
wandadars af9bf1d
updated comments for two-point control methods
wandadars 1ae0032
[Test] Reduce pruning threshold to prevent oscillations
speth f7faff4
added a documentation section and an example
wandadars 81b7eeb
[1D] Avoid output of unused solution components
speth 15e8efc
Fix two-point functions with missing return values
speth d9f6124
updated governing equations section with more details on two-point me…
wandadars ee3b077
updated svg diagram to remove whitespace
wandadars f0b4900
doxygen comment updates & exceptions added for two-point method
wandadars aee2e26
updates to docstrings, code logic, and tests for two-point control
wandadars 354fb02
added tests for two-point control method, not working for some
wandadars cbbf23a
improved comments for control point picking, added more tests, update…
wandadars 9c29512
formatting changes & documentation/samples tweaks
wandadars 5501ae5
fixed whitespace errors
wandadars cf9482d
[1D] Be more consistent about setting diag=0
speth a52f661
[1D] Update formatting related to two point flame control
speth File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
330 changes: 330 additions & 0 deletions
330
doc/sphinx/_static/images/two_point_control_diagram.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a nice diagram. I think all it needs is to have the bounding box adjusted so it doesn't require a bunch of blank space above and below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I switched it to a .png as that allowed me to control the image size. The other format was a .svg that people could potentially edit if desired, but that didn't allow me to control how it rendered.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I fixed it, I just selected the diagram in Inkscape and then exported that selection as a .svg file and when I preview it, it seems to have all that extra white space removed. I'll keep the svg in there for maintainability.