Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some failing CI jobs #1630

Merged
merged 3 commits into from
Oct 4, 2023
Merged

Fix some failing CI jobs #1630

merged 3 commits into from
Oct 4, 2023

Conversation

speth
Copy link
Member

@speth speth commented Oct 2, 2023

Changes proposed in this pull request

  • Replace Clang 12 with Clang 14, based on updates to versions available on GitHub Actions runners
  • Pin the version of MinGW installed by the setup-mingw action. This unfortunately slows down these builds a lot. There's already an issue created upstream (The plugin now no longer works on x86 egor-tensin/setup-mingw#14). Hopefully we can unpin once this is resolved.

Checklist

  • The pull request includes a clear description of this code change
  • Commit messages have short titles and reference relevant issues
  • Build passes (scons build & scons test) and unit tests address code coverage
  • Style & formatting of contributed code follows contributing guidelines
  • The pull request is ready for review

GitHub Actions runner was updated to remove Clang 12
Fixes failing builds, pending updates to the setup-mingw action
SConstruct Outdated Show resolved Hide resolved
This allows using the generic 'cc' and 'c++' symlinks that are
available on many systems.
@speth speth merged commit 7eed1bd into Cantera:main Oct 4, 2023
38 of 39 checks passed
@speth speth deleted the ci-fixes branch July 23, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants