-
-
Notifications
You must be signed in to change notification settings - Fork 355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added descriptive error text to assert statements #1816
Conversation
Hi! Thanks for making this change. I think this is definitely an improvement. Since you're editing these lines anyways, ideally we would actually change these into full Please also address the changes suggested by the linter: https://github.com/Cantera/cantera/actions/runs/11936944028/job/33273168168?pr=1816, in particular making sure not to introduce any extra spaces at the ends of lines. You can continue to push changes to this branch to update the pull request. Thank you! |
As requested by @brianweber. Made syntax of other ValueError statements consistent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the quick updates! Just one more tiny change to the formatting
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1816 +/- ##
==========================================
- Coverage 73.26% 73.25% -0.02%
==========================================
Files 383 383
Lines 54621 54625 +4
Branches 9099 9103 +4
==========================================
- Hits 40017 40013 -4
- Misses 11601 11605 +4
- Partials 3003 3007 +4 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Thank you! The test failures on macOS don't seem related to the changes here, but let's see what happens this time. I will merge this as soon as the tests look good! |
Changes proposed in this pull request
assert
statements in interfaces/cython/cantera/composite.pyCloses #
If applicable, provide an example illustrating new features this pull request is introducing
Checklist
scons build
&scons test
) and unit tests address code coverage