-
-
Notifications
You must be signed in to change notification settings - Fork 355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve test coverage of transport calculations and fix related bugs #1825
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1825 +/- ##
==========================================
+ Coverage 73.23% 73.54% +0.30%
==========================================
Files 383 383
Lines 54652 54653 +1
Branches 9109 9105 -4
==========================================
+ Hits 40027 40197 +170
+ Misses 11612 11458 -154
+ Partials 3013 2998 -15 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@speth ... while I realize that this is work-in-progress, I have one minor comment.
The 'delta' parameter which is used to determine the scale the gradient was not being used in the calculation.
a157e50
to
58ad205
Compare
If these invert() calls fail, they will raise an exception, not return an error code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @speth, this all looks good to me!
Changes proposed in this pull request
MultiTransport::getMassFluxes
andMultiTransport::getMolarFluxes
mixGasTransport
andmultiGasTransport
tests to GTest suiteChecklist
scons build
&scons test
) and unit tests address code coverage