Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve test coverage of transport calculations and fix related bugs #1825

Merged
merged 16 commits into from
Dec 12, 2024

Conversation

speth
Copy link
Member

@speth speth commented Dec 6, 2024

Changes proposed in this pull request

  • Fix spatial scaling in MultiTransport::getMassFluxes and MultiTransport::getMolarFluxes
  • Fix handling of actual versus reduced temperature when setting fits to collision integrals
  • Ensure recalculation of properties after changes to transport polynomial fits
  • Add bounds checks when accessing transport polynomial fits
  • Move mixGasTransport and multiGasTransport tests to GTest suite
  • Add various tests to improve coverage of transport-related code
  • Remove some unnecessary error checking

Checklist

  • The pull request includes a clear description of this code change
  • Commit messages have short titles and reference relevant issues
  • Build passes (scons build & scons test) and unit tests address code coverage
  • Style & formatting of contributed code follows contributing guidelines
  • The pull request is ready for review

Copy link

codecov bot commented Dec 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.54%. Comparing base (80c0bb2) to head (ec1dd12).
Report is 16 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1825      +/-   ##
==========================================
+ Coverage   73.23%   73.54%   +0.30%     
==========================================
  Files         383      383              
  Lines       54652    54653       +1     
  Branches     9109     9105       -4     
==========================================
+ Hits        40027    40197     +170     
+ Misses      11612    11458     -154     
+ Partials     3013     2998      -15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ischoegl ischoegl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@speth ... while I realize that this is work-in-progress, I have one minor comment.

src/transport/GasTransport.cpp Outdated Show resolved Hide resolved
src/transport/MultiTransport.cpp Outdated Show resolved Hide resolved
@speth speth force-pushed the test-coverage-12-2024 branch from a157e50 to 58ad205 Compare December 10, 2024 20:00
If these invert() calls fail, they will raise an exception, not
return an error code.
@speth speth changed the title WIP: Improve test coverage of transport calculations Improve test coverage of transport calculations and fix related bugs Dec 11, 2024
@speth speth marked this pull request as ready for review December 11, 2024 15:37
Copy link
Member

@ischoegl ischoegl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @speth, this all looks good to me!

@ischoegl ischoegl merged commit a60ff4d into Cantera:main Dec 12, 2024
59 checks passed
@speth speth deleted the test-coverage-12-2024 branch December 12, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants