Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overhaul of MATLAB Interface #7

Closed
ischoegl opened this issue Nov 2, 2019 · 3 comments
Closed

Overhaul of MATLAB Interface #7

ischoegl opened this issue Nov 2, 2019 · 3 comments
Labels
feature-request New feature request

Comments

@ischoegl
Copy link
Member

ischoegl commented Nov 2, 2019

Is your feature request related to a problem? Please describe

The existing MATLAB toolbox only implements a subset of Cantera features and is difficult to maintain.

Describe the desired solution

Completely replace the existing CLIB solution with a solution where MATLAB calls Python instead of a compiled MEX function that is routed through a C layer. This will require a complete rewrite of MATLAB classes to wrap the interface, preferably using the modern implementation of MATLAB classes.

Describe alternatives you have considered

Continue as is: for the introduction of a new feature, changes are required in CLIB, MEX and MATLAB (with various magic numbers obfuscating what is actually done).

Additional context

Python-specific features, e.g. SolutionArray would become automatically available to MATLAB, without requiring separate solutions in C++.

@ischoegl ischoegl changed the title Overhaul of MATLAB interface [Feature Request] Overhaul of MATLAB Interface Nov 2, 2019
@bryanwweber
Copy link
Member

See also: https://github.com/Cantera/cantera/wiki/GSoC-2019-Ideas#re-implement-the-matlab-interface

@ischoegl
Copy link
Member Author

ischoegl commented Nov 4, 2019

Also here https://github.com/Cantera/cantera/wiki/Development-Roadmap#matlab-interface---issues

... this feature request is probably a good place to have a discussion of wrapping Python vs. the loadlibrary approach.

@speth speth transferred this issue from Cantera/cantera Dec 3, 2019
@speth speth changed the title [Feature Request] Overhaul of MATLAB Interface Overhaul of MATLAB Interface Dec 6, 2019
@speth speth added the feature-request New feature request label Dec 6, 2019
@bryanwweber
Copy link
Member

I'm going to close this in favor of #32 which has more detail from the GSoC ideas page, we well as including the detail from the Roadmap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request New feature request
Projects
None yet
Development

No branches or pull requests

3 participants