Fix new worfklow syntax - attempt #5

Cardinal-Cryptography · Aug 17, 2023 · ce50bc1 · ce50bc1
1 parent cf9f88b
commit ce50bc1
Showing 1 changed file with 16 additions and 16 deletions.
diff --git a/.github/workflows/nightly-logic-e2e-tests.yml b/.github/workflows/nightly-logic-e2e-tests.yml
@@ -50,7 +50,7 @@ jobs:
 
   build-test-node-and-runtime:
     name: Build test node and runtime
-    if: needs.check-if-featurenet-ecr-image-exists.outputs.image-exists == 'false'
+    if: ${{ needs.check-if-featurenet-ecr-image-exists.outputs.image-exists == 'false' }}
     needs: [check-if-featurenet-ecr-image-exists]
     uses: ./.github/workflows/_build-test-node-and-runtime.yml
     secrets: inherit
@@ -146,18 +146,18 @@ jobs:
           argo-host: ${{ secrets.ARGOCD_DEVNET_HOST }}
           featurenet-keys-s3bucket-name: ${{ secrets.FEATURENET_KEYS_S3BUCKET_NAME }}
 
-  slack-notification:
-    name: Slack notification
-    runs-on: ubuntu-20.04
-    needs: [runs-e2e-test-on-fe]
-    if: ${{ !cancelled() }}
-    steps:
-      - name: Checkout repository
-        uses: actions/checkout@v3
-
-      - name: Send Slack message
-        uses: ./.github/actions/slack-notification
-        with:
-          notify-on: "always"
-        env:
-          SLACK_WEBHOOK: ${{ secrets.SLACK_WEBHOOK_NIGHTLY_PIPELINE }}
+#  slack-notification:
+#    name: Slack notification
+#    runs-on: ubuntu-20.04
+#    needs: [runs-e2e-test-on-fe]
+#    if: ${{ !cancelled() }}
+#    steps:
+#      - name: Checkout repository
+#        uses: actions/checkout@v3
+#
+#      - name: Send Slack message
+#        uses: ./.github/actions/slack-notification
+#        with:
+#          notify-on: "always"
+#        env:
+#          SLACK_WEBHOOK: ${{ secrets.SLACK_WEBHOOK_NIGHTLY_PIPELINE }}