Skip to content

Commit

Permalink
Fix issue with secrets
Browse files Browse the repository at this point in the history
  • Loading branch information
moicalcob committed May 29, 2024
1 parent 46c934e commit 5dc259b
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 4 deletions.
14 changes: 10 additions & 4 deletions .github/actions/publish-release/action.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,12 @@ inputs:
trigger-action:
description: "Action that triggered the release"
required: true
gcloud-service-account:
description: "Service account key for Google Cloud"
required: true
replicated-api-token:
description: "API token for Replicated"
required: true

gcloud-version:
description: "Version of the Google Cloud SDK to use"
Expand All @@ -38,14 +44,14 @@ runs:
- name: Google Cloud Auth
uses: google-github-actions/auth@v0
with:
credentials_json: ${{ secrets.CARTO_ARTIFACTS_SERVICE_ACCOUNT }}
project_id: ${{ input.artifacts-gcp-project-id }}
credentials_json: ${{ inputs.gcloud-service-account }}
project_id: ${{ inputs.artifacts-gcp-project-id }}

# Step 2: Install Gcloud CLI
- name: Google Cloud install
uses: google-github-actions/setup-gcloud@v0
with:
project_id: ${{ input.chart-gcp-project-id }}
project_id: ${{ inputs.chart-gcp-project-id }}
version: ${{ inputs.gcloud-version }}

# Step 3: Install helm
Expand Down Expand Up @@ -87,7 +93,7 @@ runs:
shell: bash
env:
REPLICATED_APP: carto
REPLICATED_API_TOKEN: ${{ secrets.REPLICATED_API_TOKEN }}
REPLICATED_API_TOKEN: ${{ inputs.replicated-api-token }}
run: |
cp carto-${{ inputs.version }}*.tgz manifests/
replicated release create --auto \
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/official-release.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,8 @@ jobs:
version: ${{ steps.release-info.outputs.version }}
release-notes: "CARTO Self-Hosted ${{ steps.release-info.outputs.version }}"
trigger-action: ${{ github.event.action }}
gcloud-service-account: ${{ secrets.CARTO_ARTIFACTS_SERVICE_ACCOUNT }}
replicated-api-token: ${{ secrets.REPLICATED_API_TOKEN }}

- name: Slack notification
if: github.event.action == 'released'
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -28,3 +28,5 @@ jobs:
version: ${{ steps.release-info.outputs.version }}
release-notes: "CARTO Self-Hosted ${{ steps.release-info.outputs.version }}"
trigger-action: ${{ github.event.action }}
gcloud-service-account: ${{ secrets.CARTO_ARTIFACTS_SERVICE_ACCOUNT }}
replicated-api-token: ${{ secrets.REPLICATED_API_TOKEN }}

0 comments on commit 5dc259b

Please sign in to comment.