Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add emscripten support #509

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Add emscripten support #509

wants to merge 3 commits into from

Conversation

bugra9
Copy link

@bugra9 bugra9 commented Jul 17, 2022 •
edited
Loading

Related issue: #510

@bugra9 bugra9 mentioned this pull request Jul 17, 2022
Open
mtehver
mtehver reviewed Jul 26, 2022
View reviewed changes
Copy link
Contributor

@mtehver mtehver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added some suggestions and few places that need addressing.

all/native/utils/Log.cpp Outdated Show resolved Hide resolved
emscripten/native/graphics/BitmapCanvasEmscriptenImpl.cpp Outdated Show resolved Hide resolved
emscripten/native/network/HTTPClientEmscriptenImpl.cpp Outdated Show resolved Hide resolved
emscripten/native/ui/MapView.h Outdated Show resolved Hide resolved
emscripten/native/ui/MapView.cpp Outdated Show resolved Hide resolved
emscripten/native/ui/EmscriptenInput.cpp Outdated Show resolved Hide resolved
emscripten/native/ui/EmscriptenInput.cpp Outdated Show resolved Hide resolved
@bugra9
- Used emscripten_log instead of printf.
2e90bc5 
- Used request.method instead of 'GET' in network/HTTPClientEmscriptenImpl.cpp.
- Set headers to http request in network/HTTPClientEmscriptenImpl.cpp.
- Used 'std::atomic<bool>' type for '_needRedraw' variable in MapView.
- Set alpha, depth and stencil to 1. (SDK uses alpha channel, depth buffer and stencil buffer.) (Fixed 3d model transparency issue.)
- Removed double click handler.
- Added additional EmscriptenInput namespace in ui/EmscriptenInput.(h/cpp)
- Changed raster map url with cartocdn.
@bugra9
Implemented BitmapCanvas to render Text and Popup vector elements.
b22980e 
Added text and popup example.
Implemented OffscreenCanvas usage.
Added vector tile event listener example.
@bugra9
Copy link
Author

bugra9 commented Oct 23, 2022

@mtehver, I implemented your suggestions and updated the demo site. Additionally, the listeners now work.

@bugra9 bugra9 requested a review from mtehver November 8, 2022 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtehver mtehver Awaiting requested review from mtehver

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bugra9 @mtehver