Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a argument to skip interactive question on upload failure #138

Conversation

thedae
Copy link
Contributor

@thedae thedae commented Mar 28, 2024

Proposed Changes

When a raster upload fails, we're asking for a yes/no input to cleanup the recently uploaded resources

When this happens in a non-interactive context like import worker, the process gets stuck

The objective of these changes is to add a --cleanup-on-failure parameter to skip the question for all providers

@thedae thedae requested a review from Jesus89 March 28, 2024 08:25
Copy link

Copy link
Contributor

@jgoizueta jgoizueta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
I wonder if we may need an opposite options (keep partial results) at some time (could be handy for debugging), but this is all we need now

@Jesus89 Jesus89 merged commit f40c82f into main Apr 2, 2024
4 checks passed
@thedae thedae deleted the feature/sc-399160/add-a-cli-parameter-to-skip-interactive-questions branch April 2, 2024 12:48
@Jesus89 Jesus89 mentioned this pull request Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants