Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle unsupported implementation queries #125

Open
csadorf opened this issue Sep 3, 2020 · 3 comments
Open

Handle unsupported implementation queries #125

csadorf opened this issue Sep 3, 2020 · 3 comments
Labels
UX User eXperience

Comments

@csadorf
Copy link
Collaborator

csadorf commented Sep 3, 2020

Trying to query the Crystallographic Open Database (CoD) I get the following error:
Screen Shot 2020-09-03 at 3 55 51 PM

@csadorf csadorf added the bug Something isn't working label Sep 3, 2020
@CasperWA
Copy link
Owner

CasperWA commented Sep 3, 2020

Thanks for the report @csadorf!
And yup. Known bug. I need to figure out the counter-measures for databases that do not support certain filterings.

There are indeed some ongoing efforts to improve the informational accuracy of which properties are queryable and/or supported by a database. This is being done currently in optimade-python-tools.
Furthermore, I will suggest we add some general and mandatory introspective keys to the OPTIMADE specification that will help implement this degree of informational accuracy further for custom implementations (like the one for COD).

@CasperWA CasperWA added UX User eXperience and removed bug Something isn't working labels Sep 29, 2020
@CasperWA
Copy link
Owner

Just to be clear concerning this issue. It is mandatory to support queries on this property (nsites) according to the OPTIMADE specification.

So this issue is mainly related to the UX and how to deal with queries (mandatory or not) that a server implementation does not support.

@CasperWA CasperWA changed the title CoD Query: "queries are not supported for 'nsites'" Handle unsupported implementation queries Sep 29, 2020
@merkys
Copy link

merkys commented Nov 4, 2020

Just to be clear concerning this issue. It is mandatory to support queries on this property (nsites) according to the OPTIMADE specification.

Correct. This issue is a known bug at the COD site (#829) and we are working to fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UX User eXperience
Projects
None yet
Development

No branches or pull requests

3 participants