Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove appmode from binder postBuild #205

Merged
merged 1 commit into from
Nov 4, 2020
Merged

Remove appmode from binder postBuild #205

merged 1 commit into from
Nov 4, 2020

Conversation

CasperWA
Copy link
Owner

@CasperWA CasperWA commented Nov 4, 2020

Fixes #204

Show on binder.

@codecov
Copy link

codecov bot commented Nov 4, 2020

Codecov Report

Merging #205 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #205   +/-   ##
========================================
  Coverage    35.96%   35.96%           
========================================
  Files           17       17           
  Lines         2138     2138           
========================================
  Hits           769      769           
  Misses        1369     1369           
Flag Coverage Δ
optimade-client 35.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d802d5...98a4da4. Read the comment docs.

@CasperWA CasperWA merged commit ab7ea03 into develop Nov 4, 2020
@CasperWA CasperWA deleted the fix_binder branch November 4, 2020 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The binder link appears to be broken
1 participant