PR review fixes

CelestiaProject · Nov 1, 2023 · 56a371d · 56a371d
1 parent 4597a10
commit 56a371d
Show file tree

Hide file tree

Showing 10 changed files with 88 additions and 178 deletions.
diff --git a/src/celengine/simulation.cpp b/src/celengine/simulation.cpp
@@ -180,12 +180,9 @@ const Observer& Simulation::getObserver() const
 }
 
 
-
-Observer* Simulation::addObserver()
+Observer* Simulation::duplicateActiveObserver()
 {
-    Observer* o = new Observer();
-    observers.push_back(o);
-    return o;
+    return observers.emplace_back(new Observer(*getActiveObserver()));
 }
 
 

diff --git a/src/celengine/simulation.h b/src/celengine/simulation.h
@@ -100,7 +100,7 @@ class Simulation
     void setObserverOrientation(const Eigen::Quaternionf&);
     void reverseObserverOrientation();
 
-    Observer* addObserver();
+    Observer* duplicateActiveObserver();
     void removeObserver(Observer*);
     Observer* getActiveObserver();
     const Observer* getActiveObserver() const;

diff --git a/src/celestia/celestiacore.cpp b/src/celestia/celestiacore.cpp
@@ -1962,7 +1962,7 @@ void CelestiaCore::draw()
     nFrames++;
     if (nFrames == 100 || sysTime - fpsCounterStartTime > 10.0)
     {
-        timeInfo.fps = (double) nFrames / (sysTime - fpsCounterStartTime);
+        timeInfo.fps = (float) nFrames / (sysTime - fpsCounterStartTime);
         nFrames = 0;
         fpsCounterStartTime = sysTime;
     }