Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[win] Delete Help/Demo Menu Item #1942

Merged
merged 1 commit into from
Oct 18, 2023
Merged

Conversation

dave-kaye
Copy link
Contributor

Delete Demo submenu item under Help menu that is inactive after commit 21f526.

Delete Demo submenu item under Help menu that is inactive after commit 21f526.
@dave-kaye
Copy link
Contributor Author

Commit 21f526 removed the demo key from user interfaces. For the Windows interface, it transferred demo activation to a Demo submenu item in the File menu. An existing Demo submenu item in the Help menu became inactive, and was overlooked. This code removes the Help menu entry and associated code. It also moves the existing icon to the File menu item.

All three interfaces (win32, GTK and Qt) presently use the File menu entry for the Demo script activation.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Collaborator

@ajtribick ajtribick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ajtribick ajtribick merged commit 3ab9579 into CelestiaProject:master Oct 18, 2023
11 checks passed
@dave-kaye dave-kaye deleted the windemo branch October 19, 2023 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants