[cmake] Allow enabling LTO for Qt frontend and libcelestia.so #1955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
MSVC doesn't like something. |
|
Tried this locally, it works with the Ninja generator but not the Visual Studio one. Need to figure out why but supplying |
|
Ok further investigation - Ninja doesn't work either, but it was passing a build configuration of RelWithDebInfo while MSVC was translating this to Release, so Ninja didn't use LTO. The reason appears to be that WINDOWS_EXPORT_ALL_SYMBOLS is not compatible with LTO for DLLs - we'd probably have to mark the relevant functions with the appropriate __dllspec attributes, or compile the celestia library as static rather than shared. |
In member function ‘addTreeItemChildrenFiltered’,
inlined from ‘createTreeItem’ at src/celestia/qt/qtsolarsystembrowser.cpp:280:36:
src/celestia/qt/qtsolarsystembrowser.cpp:349:51: warning: argument 1 value ‘18446744073709551615’ exceeds maximum object size 9223372036854775807 [-Walloc-size-larger-than=]
349 | item->children = new TreeItem*[item->nChildren];
|
Kudos, SonarCloud Quality Gate passed! |
375gnu
changed the title
375gnu
changed the title
ajtribick
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main code and Qt5 frontend benefit from LTO. Gtk+ and SDL frontends increase their sizes, i think it's due to statically linked libfmt.
g++ is 7.5.0. Other compilers may give other numbers.
With g++12.2 and 1.10.1: