Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[win] Do not process ka.po for Windows front-end #1965

Merged
merged 1 commit into from
Nov 4, 2023

Conversation

ajtribick
Copy link
Collaborator

@ajtribick ajtribick commented Nov 4, 2023

Currently we can't support Georgian in the Windows front-end since there is no 8-bit code page to support it. Maybe if we change the Windows front-end to use the Unicode wide character APIs instead we can re-enable this.

Qt should still work here.

For now this should unbreak the build, created issue #1966 for the Windows front-end rewrite.

@ajtribick ajtribick requested a review from a team November 4, 2023 16:10
Copy link

sonarqubecloud bot commented Nov 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Collaborator

@375gnu 375gnu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, i forgot about this file completelly

@ajtribick ajtribick merged commit 9a3c8bb into CelestiaProject:master Nov 4, 2023
11 checks passed
@ajtribick ajtribick deleted the no-win-ka branch November 4, 2023 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants