Skip to content

Commit

Permalink
Use institution banner image for all size screens
Browse files Browse the repository at this point in the history
  • Loading branch information
futa-ikeda committed Oct 5, 2023
1 parent 2005eee commit 398a10a
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 14 deletions.
18 changes: 5 additions & 13 deletions lib/osf-components/addon/components/search-page/template.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -18,19 +18,11 @@ as |layout|>
{{html-safe @provider.description}}
</p>
{{else if @institution}}
{{#if this.showSidePanelToggle}}
<img
data-test-institution-logo
src={{@institution.logoRoundedUrl}}
alt={{concat (t 'search.institutions.institution-logo') @institution.name}}
>
{{else}}
<img
data-test-institution-banner
src={{@institution.bannerUrl}}
alt={{concat (t 'search.institutions.institution-logo') @institution.name}}
>
{{/if}}
<img
data-test-institution-banner
src={{@institution.bannerUrl}}
alt={{concat (t 'search.institutions.institution-logo') @institution.name}}
>
<p local-class='provider-description' data-test-institution-description>{{html-safe @institution.description}}</p>
{{else}}
<label
Expand Down
2 changes: 1 addition & 1 deletion tests/acceptance/institutions/discover-test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ module('Acceptance | institutions | discover', hooks => {
await visit('/institutions/has-users');
assert.equal(currentURL(), '/institutions/has-users', 'Current route is institutions discover');
// verify logo and description
assert.dom('[data-test-institution-logo]').exists('Institution header logo shown');
assert.dom('[data-test-institution-banner]').exists('Institution banner shown');
assert.dom('[data-test-institution-description]').exists('Institution description is shown');
// verify mobile menu display
assert.dom('[data-test-topbar-wrapper]').doesNotExist('Topbar not shown on mobile');
Expand Down

0 comments on commit 398a10a

Please sign in to comment.