A11y (#2404)

CenterForOpenScience · Nov 19, 2024 · 6c2996b · 6c2996b
1 parent 54b4eb9
commit 6c2996b
Show file tree

Hide file tree

Showing 5 changed files with 17 additions and 6 deletions.
diff --git a/app/institutions/dashboard/-components/institutional-users-list/component.ts b/app/institutions/dashboard/-components/institutional-users-list/component.ts
@@ -142,7 +142,7 @@ export default class InstitutionalUsersList extends Component<InstitutionalUsers
     // Private properties
     @tracked hasOrcid = false;
     @tracked totalUsers = 0;
-    orcidUrlPrefix = 'https://orcid.org/'; // Move to config?
+    orcidUrlPrefix = 'https://orcid.org/';
 
     @action
     toggleColumnSelection(columnKey: string) {

diff --git a/app/institutions/dashboard/-components/institutional-users-list/template.hbs b/app/institutions/dashboard/-components/institutional-users-list/template.hbs
@@ -73,6 +73,7 @@
                         <OsfLink
                             data-test-link-to-reports-archive
                             data-analytics-name='Link to archived reports'
+                            aria-label={{t 'institutions.dashboard.download_past_reports_label'}}
                             @target='_blank'
                             @fakeButton={{true}}
                             @href={{@institution.linkToExternalReportsArchive}}
@@ -85,7 +86,11 @@
                     {{/if}}
                     <div local-class='download-dropdown'>
                         <ResponsiveDropdown @renderInPlace={{true}} @buttonStyling={{true}} as |dd| >
-                            <dd.trigger data-test-download-dropdown local-class='download-dropdown-trigger'>
+                            <dd.trigger
+                                data-test-download-dropdown
+                                aria-label={{t 'institutions.dashboard.download_dropdown_label'}}
+                                local-class='download-dropdown-trigger'
+                            >
                                 <FaIcon @icon='download' />
                             </dd.trigger>
                             <dd.content local-class='download-dropdown-content'>

diff --git a/app/institutions/dashboard/-components/object-list/template.hbs b/app/institutions/dashboard/-components/object-list/template.hbs
@@ -72,6 +72,7 @@ as |list|>
                                     <OsfLink
                                         data-test-link-to-reports-archive
                                         data-analytics-name='Link to archived reports'
+                                        aria-label={{t 'institutions.dashboard.download_past_reports_label'}}
                                         @target='_blank'
                                         @fakeButton={{true}}
                                         @href={{@institution.linkToExternalReportsArchive}}
@@ -86,7 +87,11 @@ as |list|>
                                 </div>
                             {{/if}}
                             <ResponsiveDropdown @renderInPlace={{true}} @buttonStyling={{true}} as |dd| >
-                                <dd.trigger data-test-download-dropdown local-class='download-dropdown-trigger'>
+                                <dd.trigger
+                                    data-test-download-dropdown
+                                    aria-label={{t 'institutions.dashboard.download_dropdown_label'}}
+                                    local-class='download-dropdown-trigger'
+                                >
                                     <FaIcon @icon='download' />
                                 </dd.trigger>
                                 <dd.content local-class='download-dropdown-content'>
@@ -97,8 +102,8 @@ as |list|>
                                         {{t 'institutions.dashboard.format_labels.csv'}}
                                     </Button>
                                     <Button
-                                           local-class='download-option'
-                                           {{on 'click' (queue this.downloadTsv dd.close)}}
+                                        local-class='download-option'
+                                        {{on 'click' (queue this.downloadTsv dd.close)}}
                                     >
                                         {{t 'institutions.dashboard.format_labels.tsv'}}
                                     </Button>

diff --git a/lib/osf-components/addon/components/adjustable-paginator/template.hbs b/lib/osf-components/addon/components/adjustable-paginator/template.hbs
@@ -1,6 +1,6 @@
 <span local-class='paginator__control'>
     <div local-class='paginator__select-wrapper'>
-        <select id='pageSizeSelect' local-class='paginator__select' onchange={{action this.onPageSizeChange value='target.value'}}>
+        <select title={{t 'paginator.itemsPerPage'}} local-class='paginator__select' onchange={{action this.onPageSizeChange value='target.value'}}>
             {{#each this.pageSizeOptions as |page_size_option|}}
                 <option value={{page_size_option}} selected={{eq page_size_option this.selectedPageSize}}>
                     {{t 'paginator.itemsPerPage'}} {{page_size_option}}

diff --git a/translations/en-us.yml b/translations/en-us.yml
@@ -812,6 +812,7 @@ institutions:
         content-placeholder: Content coming soon # Delete this eventually pls
         title: '{institutionName} Dashboard'
         download_past_reports_label: 'Previous reports'
+        download_dropdown_label: 'Download data'
         download_csv: 'Download CSV'
         download_tsv: 'Download TSV'
         format_labels: