Skip to content

Commit

Permalink
fix: z-index shenaningans
Browse files Browse the repository at this point in the history
the contents of an ember-basic-dropdown have `z-index: 1000`,
while an osf-dialog had `z-index: 1100` -- when a dropdown is inside a
dialog, this is a problem (the dropdown is hidden behind the dialog)

however, osf-dialog should be in front of the branded navbar, which has
`z-index: 999` -- this fix bumps branded-navbar down to `998` and
osf-dialog down to `999`, both safely behind the dropdown at `1000`.
  • Loading branch information
aaxelb committed Oct 13, 2023
1 parent 5f4959d commit f2f0d76
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

.branded-nav-wrapper {
.branded-nav {
z-index: 999;
z-index: 998;
}

:global(.navbar) {
Expand Down
2 changes: 1 addition & 1 deletion lib/osf-components/addon/components/osf-dialog/styles.scss
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
align-items: center;
justify-content: center;

z-index: 1100;
z-index: 999;
background-color: rgba(0, 0, 0, 0.5);
}

Expand Down

0 comments on commit f2f0d76

Please sign in to comment.