Basket/barium #2008
Merged
Basket/barium #2008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…#1889) ## Purpose Un-silence the deprecation `manager-capabilities.modifiers-3-13` and fix the resulting problems ## Summary of Changes 1. Unsilence deprecation 2. Upgrade ember-auto-import to v2 3. Upgrade ember-modifiers 4. Upgrade ember-moment and imports 5. Spread moment around all the engines 6. Refactor modifiers to work with new api for ember-modifiers 7. Remove unused modifier 8. Fix usage of side-effect from ember computed to give ember power select a placeholder in institutional dashboard ## Side Effects If I didn't fix the modifiers right, something may have broken there silently.
# Conflicts: # package.json
## Purpose Staging2 is broken because we can't find `chunk*.js` and it looks like that's because we need to add our `assetsPrefix` to ember-auto-import to make it work. This fix seems to work locally, but it works locally without the fix, so we'll see what actually happens on staging2. ## Summary of Changes 1. Fix the missing asset prefix
## Purpose Upgrade ember to 3.28 ## Summary of Changes 1. Match ember dependencies to `ember new` blueprint 2. Fix all the problems 3. Modify getApiErrorMessage to re-throw in the case of no API error message (some problems fixed h/t @futa-ikeda)
## Purpose Ember-cli-clipboard was doing deprecated things, and upgrading it was a nightmare. The actual functionality is trivial to implement, though, so we've made our own version of its copy button. ## Summary of Changes 1. Add copy button 2. Add tests
## Purpose See if a weird bug gets fixed on staging2 by removing a slightly risky re-throw of error messages. ## Summary of Changes 1. Don't re-throw error message
## Purpose Help to be able to debug situations where the registries overview page goes to the not-found page inappropriately. ## Summary of Changes 1. Send the error to sentry after transitioning to page not found.
## Purpose When upgrading to ember 3.28, we lost the ability to distinguish between dirty relationships and clean ones when PATCHing a record, so we would send all the relationships. This was a problem because many of the clean relationships in the serializer had null information, which broke the API, because it doesn't like PATCHed relationships with null information. This fixes that by removing any relationship that is just null info in the serializer. We will still sometimes PATCH relationships we don't need to, but the info should be the same and thus not cause problems for the API. ## Summary of Changes 1. Scan for null relationships in osf-serializer and remove them from the request payload.
## Purpose The infinite scroller stopped working because the component that manages if it's in the viewport was not compatible with the new modifiers until it was updated. ## Summary of Changes 1. Update ember-in-viewport
## Purpose Properly remove clean relationships from a PATCH request. ## Summary of Changes 1. Get the graph 2. Scan the graph for changes in each relationship in the serializer 3. Remove the relationship from the serializer if there are no changes 4. Types
## Purpose Make registrations load on basket/barium release ## Summary of Changes 1. Make relationships polymorphic
## Purpose - Address deprecation: [has-block-and-has-block-params](https://deprecations.emberjs.com/v3.x#toc_has-block-and-has-block-params) ## Summary of Changes - Remove `ember-cli-password-strength` and use `zxcvbn` directly - Remove `ember-promise-helpers` as it doesn't seem to be used - Update liquid-fire - Update ember-radio-buttons - Remove deprecation silencer Co-authored-by: Brian J. Geiger <bgeiger@pobox.com>
# Conflicts: # tests/engines/registries/acceptance/discover-page-test.ts # tests/engines/registries/acceptance/landing-page-test.ts
## Purpose
Eliminate this-property-fallback deprecation errors. Might want to review this commit-by-commit. The removal of ember-get-config added a bunch of noise.
## Summary of Changes
1. Upgrade ember-sortable
2. Fix tests that failed this deprecation
3. Upgrade:
- ember-cli-showdown
- tag-input
- Ember-collapsible-panel
- Ember-content-placeholders
- Ember-radio-button
4. Remove ember-get-config
5. Move environment.d.ts
6. Fix tests
## Purpose Fix deprecation route-render-template ## Summary of Changes 1. Unsilence the deprecation
…-flatpickr (#1982) * fix deprecation by upgrading ember-flatpickr * use null as date param for ember-flatpickr
…responsive and ember-intl; fix `ember.built-in-components.legacy-arguments` (#1983)
…r.built-in-components.reopen` (#1987)
## Purpose Try to fix a selenium test that was broken when we re-wrote the clipboard button. ## Summary of Changes 1. Add data selector
## Purpose There are two major parts to fixing the try-invoke deprecation. The first is updating ember-composable-helpers, and the second is removing ember parachute. This handles the first. The second will be part of Search Phase 2 once the branded registries discovery page, which is the page that uses ember-parachute, is removed. ## Summary of Changes 1. Update ember-composable-helpers
## Purpose A recent deprecation fix caused meetings searches to break. This should fix that. ## Summary of Changes 1. Add `target` string to `on` actions
## Purpose Fix some build-time deprecations. Everything I know about except for https://deprecations.emberjs.com/v3.x/#toc_ember-global ## Summary of Changes 1. Upgrade ember power select 2. Upgrade Node 3. Remove node-sass 4. Remove ember-component-attributes 5. Fix usage of htmlSafe 6. Upgrade ember-cli-string-helpers 7. Remove unused osf-logo component 8. Update and remove various other dependencies ## Side effects Builds may be a bit faster. I'm getting between 45 and 60ish second builds, although this may only be true for M1 and M2 chips. Could be slower on Intel. Also, we'll get a bunch of extraneous notices in the buld process like `unexpectedly found "<Pane" when slicing source, but expected "class"`. This is unfortunate but expected and isn't supposed to hurt anything.
## Purpose Placeholder text went away on the sign-up page. This restores the placeholders. ## Summary of Changes 1. Send the placeholders to the component properly.
adlius
approved these changes
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Upgrade Ember to 3.28