Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Result counts #2017

Merged
merged 2 commits into from
Oct 6, 2023
Merged

Result counts #2017

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6dccdd0
Show results counts for mobile preprint/registry discover page
futa-ikeda Oct 6, 2023
df96fde
Grammar for result counts
futa-ikeda Oct 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/osf-components/addon/components/search-page/component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ export default class SearchPage extends Component<SearchArgs> {
}

get showResultCountLeft() {
return this.totalResultCount && this.args.showResourceTypeFilter;
return this.totalResultCount && (this.args.showResourceTypeFilter || this.showSidePanelToggle);
}

get selectedSortOption() {
Expand Down
5 changes: 5 additions & 0 deletions lib/osf-components/addon/components/search-page/styles.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,11 @@
width: 195px;
}
}

.search-count {
// override RegistriesStyle
font-size: 1.5em;
}
}

.search-main-mobile {
Expand Down
2 changes: 1 addition & 1 deletion translations/en-us.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,7 +233,7 @@ search:
textbox-placeholder: 'Enter search term(s) here'
search-button-label: 'Search'
search-help-label: 'Help tutorial'
total-results: '{count} results'
total-results: '{count} {count, plural, one {result} other {results} }'
no-results: 'No results found'
resource-type:
search-by: 'Search by object type'
Expand Down
Loading