Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENG-4091] Linked Projects Modal Close Button #2018

Merged
merged 8 commits into from
Oct 11, 2023
Merged

[ENG-4091] Linked Projects Modal Close Button #2018

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
ce6c3b5
Updated styling for OsfDialog modal for mobile.
chth0n1x Oct 6, 2023
59d642f
Simplified styles for HeadingWrapper.
chth0n1x Oct 6, 2023
4f01735
Removed additional line in file.
chth0n1x Oct 6, 2023
f936adf
Removed unnecessary styling for modal.
chth0n1x Oct 9, 2023
b90e695
Updated z-index on dialog background to work regardless of screen hei…
chth0n1x Oct 9, 2023
9c55a3a
Updated fix for modal to overlap navbar by request.
chth0n1x Oct 9, 2023
eec336f
Updated padding statements to be inline.
chth0n1x Oct 9, 2023
bfa7425
Merge branch 'develop' into linked-projects-modal-close
chth0n1x Oct 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions lib/osf-components/addon/components/osf-dialog/heading/styles.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,3 +18,14 @@
align-self: flex-start;
margin: 10px;
}

@media (min-width: 501px) and (max-width: 991px) {
.HeadingWrapper h2 {
padding: 0.75rem 1rem 0.5rem;
chth0n1x marked this conversation as resolved.
Show resolved Hide resolved
}

.CloseButton.CloseButton {
display: flex;
margin-top: 20px;
}
}
6 changes: 6 additions & 0 deletions lib/osf-components/addon/components/osf-dialog/main/styles.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,3 +3,9 @@
overflow: auto;
padding: 1rem 1.25rem;
}

@media (min-width: 501px) and (max-width: 991px) {
.Main {
max-height: 50vh;
}
}
1 change: 1 addition & 0 deletions lib/osf-components/addon/components/osf-dialog/styles.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@

.Dialog {
max-width: $width;
max-height: 55vh;
}

.Dialog.FixedWidth {
Expand Down
Loading