New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENG-4822] Adjust z-index for general osf navbar #2037

Merged

futa-ikeda merged 1 commit into CenterForOpenScience:develop from futa-ikeda:navbar-modal-z-index

Oct 24, 2023

Contributor

futa-ikeda commented Oct 23, 2023 •

edited by jira bot

Loading

Ticket: ENG-4822
Feature flag: n/a

Purpose

Place modal controls over navbar (initially resolved in ENG-4091)

Summary of Changes

Adjust z-index of navbar class to be below the DialogBackground z-index

Screenshot(s)

Prevents this behavior:

Side Effects

QA Notes


          Adjust z-index for general osf navbar

b222b6b

coveralls commented Oct 23, 2023

Pull Request Test Coverage Report for Build 6619856121

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 70.651%

Totals
Change from base Build 6618707202:	0.0%
Covered Lines:	5953
Relevant Lines:	8194

💛 - Coveralls

aaxelb approved these changes

View reviewed changes

Contributor

aaxelb left a comment

oh good catch, missed this in 3755691 🍍

futa-ikeda merged commit b2edb25 into CenterForOpenScience:develop

9 checks passed

futa-ikeda deleted the navbar-modal-z-index branch

October 24, 2023 14:58

futa-ikeda added this to the 23.13.0 milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet