Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix preprint tests #2038

Conversation

adlius
Copy link
Contributor

@adlius adlius commented Oct 24, 2023

  • Ticket: []
  • Feature flag: n/a

Purpose

Some of the tests are failing because of problems when rendering the <BrandedNavbar> component due to the fact that the <LinkTo> element haven't got the right parameter for @model.

Summary of Changes

Screenshot(s)

Side Effects

QA Notes

@bp-cos
Copy link
Contributor

bp-cos commented Oct 24, 2023

merging in the passing tests.

@bp-cos bp-cos closed this Oct 24, 2023
@bp-cos bp-cos reopened this Oct 24, 2023
@bp-cos bp-cos merged commit 5a2d8db into CenterForOpenScience:feature/preprint-details-page Oct 24, 2023
8 of 10 checks passed
@futa-ikeda futa-ikeda added this to the 23.15.0 milestone Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants