Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broaden how we find orcid ids #2039

Merged
merged 2 commits into from
Oct 25, 2023
Merged

Broaden how we find orcid ids #2039

merged 2 commits into from
Oct 25, 2023

Conversation

futa-ikeda
Copy link
Contributor

@futa-ikeda futa-ikeda commented Oct 24, 2023 •
edited by jira bot
Loading

Purpose

  • Show ORCID ids on search result cards regardless of protocol

Summary of Changes

  • Look for orcid.org in the identifiers array instead of http://orcid.org, as some results were using the https protocol in the identifier

Screenshot(s)

Side Effects

QA Notes

aaxelb
aaxelb reviewed Oct 24, 2023
View reviewed changes
app/models/search-result.ts Outdated Show resolved Hide resolved
@futa-ikeda @aaxelb
Update app/models/search-result.ts
4c890a0 
Co-authored-by: Abram Booth <aaxelb@users.noreply.github.com>
aaxelb
aaxelb approved these changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@aaxelb aaxelb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐚

@futa-ikeda futa-ikeda merged commit b4e8f4b into CenterForOpenScience:develop Oct 25, 2023
9 checks passed
@futa-ikeda futa-ikeda deleted the orcid-ids branch October 25, 2023 13:21
@futa-ikeda futa-ikeda added this to the 23.13.0 milestone Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaxelb aaxelb aaxelb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
23.13.0
Development

Successfully merging this pull request may close these issues.
2 participants
@futa-ikeda @aaxelb