[ENG-4681] Add mirage for v2 api #2051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianjgeiger
commented
Nov 13, 2023
mirage/views/external-account.ts
Outdated
| .models; | ||
| const externalAccounts = userAddons.length ? userAddons[0].externalAccounts.models : null; | ||
| if (externalAccounts) { | ||
| externalAccounts.map((model: ModelInstance<ExternalAccountsModel>) => this.serialize(model).data); |
There was a problem hiding this comment.
I think this needs an additional filter on it to filter by provider. I was so happy I got it working that I forgot that step.
futa-ikeda
approved these changes
Nov 13, 2023
| const nodeAddons = schema.nodes | ||
| .find(request.params.parentID)['nodeAddons'] | ||
| .models | ||
| .filter((m: ModelInstance<NodeAddonModel>) => filter(m, request)) |
There was a problem hiding this comment.
Forgot we have this filter util 👀
futa-ikeda
approved these changes
Nov 13, 2023
brianjgeiger
merged commit f8b33f1
into
CenterForOpenScience:feature/addon-services
9 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Make the v2 endpoints work with mirage. This includes a lot of normalization of the API but not the extra features such as extended attributes for providers nor getting the folder lists.
Summary of Changes
Screenshot(s)