Fix for routing in the FE to handle /preprints/<preprint_guid> #2052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bp-cos
force-pushed
the
feature/routing-fix
branch
from
ade9c1e to
3909869
Compare
adlius
requested changes
Nov 14, 2023
adlius
approved these changes
Nov 14, 2023
futa-ikeda
approved these changes
Nov 14, 2023
bp-cos
merged commit 035d2f6
into
CenterForOpenScience:feature/preprint-details-page
9 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Allow /preprints/<preprint_guid> to be routed correctly and a provider
Summary of Changes
Added an conditional if statement to the error handling on the index page if the provider_id fails.
Screenshot(s)
N/A
Side Effects
N/A
QA Notes
https://www.notion.so/cos/0de7c99478234fd7be57029dd96aa2d3?v=a4e6d7c70c004d27a0955aa2742775a4&p=b40cc3e5b898476b8d8434de71d9b8fc&pm=c