Fix branded navbar colors for mobile #2060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianjgeiger
approved these changes
Nov 17, 2023
futa-ikeda
merged commit 191e739
into
CenterForOpenScience:feature/preprint-details-page
9 checks passed
adlius
added a commit
that referenced
this pull request
Nov 30, 2023
* [ENG-4450] Add new share-search models (#1835) - Ticket: [ENG-4450] - Feature flag: n/a - Add new models needed for SHARE-powered search page - Add new models - `metadata-record-search` - `metadata-property-search` - `metadata-value-search` - `metadata-record` - `search-match` - New `ShareAdapter` and `ShareSerializer` to be used by these new models - New mirage endpoint for metadata-record-search (other endpoints coming later) * Add basic search page layout (#1850) * [ENG-4465] Left panel facets manager (#1858) - Ticket: [ENG-4465] [ENG-4466] - Feature flag: n/a - Add logic to search page controller to handle active filters and list of filterable properties - Add a component to handle fetching values in a filterable properties in the search page - Add a `filter-facet` component - takes care of fetching filterable property values - `See more` modal * [ENG-4469] Add object filter and sort dropdown to search (#1864) - Ticket: [ENG-4469] - Feature flag: n/a - Add object type filter and sort dropdown to search page - Add tabs to filter by object type (All, Projects, Registrations, Preprints, Files, Users) - Add dropdown to sort results by Relevance, Date modified/created ascending and descending - Change model names to reflect more library-analogy based names - Change how metadata properties are fetched from SHARE models * [No ticket] Update SHARE endpoints (#1879) - Ticket: [No ticket] - Feature flag: n/a - Update SHAREAdapter to point to correct locations - Update SHAREAdapter parent class to point use config variable for share-url - Update SHAREAdapter parent class to point use api/v3 endpoints - Update search-related adapters to point to singularized endpoint names (e.g. api/v3/index-card-search**es** -> api/v3/index-card-search - Update mirage endpoints to reflect these changes * [ENG-4568] Componentize search page (#1886) - Ticket: [ENG-4568] - Feature flag: n/a - Componentize search page for reuse in branded pages - Move logic and templating from search page route to `search-page` component - No logic for branding and default query-params yet in this PR * [ENG-4574] Preprint discover rewrite (#1896) * add brand relationship to preprint provider model (#1887) * Remove unused services from search controller * Use search-page component on preprint discover page * Modifiy branded-navbar for preprints * Error handling and theme resetting * Branded preprint discover part 1 * Branded preprint discover part 2 * Test prerpint discover page * Group CR feedback re: search-page component arguments * Fix test --------- Co-authored-by: Yuhuai Liu <yuhuai@cos.io> * [ENG-4573] Registry discover (#1900) * preliminary * moar * some more * delete unused components * remove top-level aggregate registries discover route * remove top-level registries discover route cont. * remove unused action and variable on registries application route * remove aggregate registries discover page tests * fix tests * remove discover-test.ts * CR followup * [ENG-4574] Preprint discover fixes (#1905) - Ticket: [ENG-4574] - Feature flag: n/a - Add appropriate page title to discover page - Add appropriate analytics scope to discover page - Make provider description now show html entities - Use `{{html-safe}}` when showing provider description - Add `providerTitle` in preprint-provider model - Most branded providers should show their name with their preprint word (e.g. AfricaRxiv Preprints, MarXiv Papers), except Thesis Commons - If it's OSF, we just show "OSF Preprints" - Add page-title and analytics scope using the new `providerTitle` * [ENG-4535] Search help feature (#1907) - Ticket: [ENG-4535] - Feature flag: n/a - Add search help feature - Basically a re-implementation of #1891 and #1877 - Notable difference is moving the Popovers to the end of the file to avoid merge conflicts - Added EmberPopovers to the search-page component - Added getters to search-page component to fetch EmberPopover targets dynamically - Translations - Tests * [No Ticket] Change queryparam passed to SHARE when filtering by resourceType (#1915) * change queryparam passed to SHARE when filtering by resourceType * add types * add some more types * update tests * [No ticket] Preprint branding rework (#1913) - Ticket: [] - Feature flag: n/a - Only rely on `brand` relationship for setting preprint colors - Use `brand.primaryColor` for branded navbar background color - Add styling if the brand's primaryColor does not provide sufficient contrast with white text - Add special-case for BioHackrXiv to change navbar color to white (their primary color would be white, but that creates problems for `<Button>` behavior, so their primary is black instead) - Use `brand.heroBackgroundImage` for hero banner background, as well as advisory board section when @brianpilati implements that page. Currently just a solid color - Use `brand.navbarLogoImage` for navbar logo if `preprintProvider.assets.square_color_transparent` is not defined - Update `<Button>` component to detect primary color and use white/black text depending on color contrast * Preprints branding update (#1922) - Ticket: [] - Feature flag: n/a ## Purpose - Remove possible failure point by not using preprintProvider.asset - Add special casing to address nutrixiv's navbar color https://osf.io/preprints/nutrixiv/ ## Summary of Changes - Remove use of ThemeStyles from preprint (this set the navbar logo to use the preprintProvider.asset. square_color_transparent, when we want to just use the brand. topnavLogoImage going forward) - Add special case for nutrixiv to use a white background similar to biohackrxiv * Test prerpint discover page * Group CR feedback re: search-page component arguments * Added new preprints index to the new branch * Added translation strings * Fixed a rebase * Rebase fix * Removed the add-ons and moved search-help-modal to osf-components * Fixed a merge conflict * Fixed a few git merge conflicts * Added more logic to get the page to render * Added the taxonomy top list component and integrated it into the index page * Updates to the preprints template file to remove bootstrap * Fixed the css for the taxonomy-top-list * Removed an unnecessary import for analytics * Added more information for the providers * Added the advisory board attribute * Finished the html transformation for preprints * Fixed the routing to use a single template * Updates to remove unused variables and added branding * Fixed the css for the steering committee * Updates for comments from PR * Fixed some css and updated the mirage for global classes * Updates for branding * Added more styling for mobile * Added more information for preprints * Added more information for the taxomony * Added a branded footer for preprints * Fixed the preprint provider logic ... again * Fixed the branded header search * Fixed the page title logic * Removed useless test * Move preprint specific components to the app/preprints/-components * Added taxonomy tests * Added another test * Added another test * Added additional tests for the branded header * Added Branded footer tests * Pruned an unused providerModel from the branded-header * Added more tests * Added a test file * Added the initial template and attempt to have it compiled * Added the controller and the styles -- first pass * Added a router and continued to clean-up the controller * Removed chronos * Fixed an the computed and actions * Cleaned-up computed method * Removed unused route code * Added routing and a factory to mirage for preprints * Fixed the routing, mirage and prototyped the model is working * Initial steps to update the template * mirage updates * Updated users to have html link * Added logic to have the contributors displayed using the pre-build component * Updates for preprint details * Added more details for the preprint details page * Added information for the primaryFile * Added the ability to display a pdf from a local assets * Finished the abstract section * Added the license information * Added some miscellaneous logic for licenses * Added original date published * Added tags to the preprint detail page * Added citations and a lot of stuff that I have no idea about without Futa * Added the preprint doi * Added the supplemental material * Added the download option, with metrics * Initial work on the social icons * Added the plaudit widget * Added the final touches for mobile views * Initial pass for withdrawn preprints * Initial commit for the preprint-status-banner component * Additional refactors to bring the ts file up-to-date with latest ember * Added a current state icon method * Refactored all the constants to be typescript compatible * Appears the preprint status banner will now compile * Fixed mirage logic and some refactors * Added more styling and translations * Added a bunch of serializer, mirage and scenario logic * Added a bunch of mirage love * Finished all the conditional statements for the details page * Fixing scenarios with contributors * Finished adding all the preprint checks * refactored the doi to be a stand-alone component * Renamed doi to be preprint-doi * Added the preprint-license * Added the tombstone page * Added the preprint disciplines component * pruned some code * Converted the preprint-tag page * added the tombstone component * Added the abstract component and refactored the tombstone and detail page * Added the initial author-assertions * Added the preprint assertion link * Fixed the css for author assertions, coi and data * Finished author assertion for pre registration links * Removed unecessary comments * Fixed a few issues recommended by Futa after the mega-merge * Fixed pagination for branded preprint provider, added a provider without an image for a use case that eric is presenting * Removed all the `import config from ember-get-config` * Removed some comments * Removed some commentted out router code * Defined the data-test * Removed a bootstrap and eslint-ignore * Removed comments * Removed an unnecessary max-len * Removed comments * Removed comments * Fixed a length and added an enum * Added enums to a model * Renamed a method * Removed a stale file * Refactor the brandedProvider store call * Refactored a template file * Pruned translation strings * Removed a comment * Enum name change * Updated the inverse to be target on preprint files * removed the preprint-tag/component * Removed the tombstone component * Changed String to string * Changed String to string - Part II * Refactored a string to be an enum * endingWithdrawal to pendingWithdrawal * Removed the preprint-assertion-link component * Removed the branded-footer component * Refactored some comments and enums * Added a better IRI based filter * Pruned unused code * Fixed a translation string name * Removed unnecessary branded navbar params * Fixed a return enum from the api * Moved old unused code * Added the metric start date to the controller and environment * Fixed an overly aggressive find/replace and commented out code * Fixed the query on the taxonomy-top-list component * fixed the belongsTo relationship on a file * made the branded header search placeholder dynamic * Removed the abstractDoi from the preprint doi url * Removed the abstractDoi from the article * Fixed the branded footer * Preprint review action prototype * Updated the reviewActions for the Preprint model * change LinkTo element parameter * fix branded header tests * fix taxonomy-top-list tests * fix branded header test * Updated the abstract template to use expandable-preview and removed the component * set inverse to null * Fixed build issues * fix preprint routing * attempt * try this * Removed the bibiliographic stuff and added feature switches for M1 chips * Better fix for adapters * Revert "Better fix for adapters" This reverts commit da03639. * Revert "Removed the bibiliographic stuff and added feature switches for M1 chips" This reverts commit 4344e41. * Remvoed bibliographicContributors * Fixed the edit link * Added the fix for the search button * Fixed the routing for osf and branded providers * Fixed an issue with theme.reset * Removed button * pruning code * Use gray background for preprint detail * Show preprint as active service * Use config for donate link * Add different set of navbar links for preprints * Fixed the routing for /preprints/<guid> * Fix for Yuhuai * Update for Yuhuai * Fixed the plaudit env variables * Fixed the branded footer link for preprints (#2059) * Added mobile logic to the author assetions * Fixed the styles for the status banner * Fixed the css will be non-biased * This did need a text-align: center * Allow provider-specfic default citation styles (#2056) * Fix branded navbar colors for mobile (#2060) * Fix branded navbar colors for mobile * Less whacky css rules * Fix link to my-preprints * Fixed a link * Fixed the logic for preprints with a coi of null * Preprint metadata (#2065) * Avoid double-loading citation fixture * Add logic to add metadata to head for preprint detail * Updates to fix the text on the branded search page * Move favicon logic to parent route * Fix copy-pasta * Lint --------- Co-authored-by: futa-ikeda <51409893+futa-ikeda@users.noreply.github.com> Co-authored-by: Futa Ikeda <futa.ikeda@gmail.com> Co-authored-by: Brian Pilati <brianpilati@cos.io> Co-authored-by: Lord Business <113387478+bp-cos@users.noreply.github.com>
bp-cos
added a commit
to bp-cos/ember-osf-web
that referenced
this pull request
Jan 31, 2024
* [ENG-4450] Add new share-search models (CenterForOpenScience#1835) - Ticket: [ENG-4450] - Feature flag: n/a - Add new models needed for SHARE-powered search page - Add new models - `metadata-record-search` - `metadata-property-search` - `metadata-value-search` - `metadata-record` - `search-match` - New `ShareAdapter` and `ShareSerializer` to be used by these new models - New mirage endpoint for metadata-record-search (other endpoints coming later) * Add basic search page layout (CenterForOpenScience#1850) * [ENG-4465] Left panel facets manager (CenterForOpenScience#1858) - Ticket: [ENG-4465] [ENG-4466] - Feature flag: n/a - Add logic to search page controller to handle active filters and list of filterable properties - Add a component to handle fetching values in a filterable properties in the search page - Add a `filter-facet` component - takes care of fetching filterable property values - `See more` modal * [ENG-4469] Add object filter and sort dropdown to search (CenterForOpenScience#1864) - Ticket: [ENG-4469] - Feature flag: n/a - Add object type filter and sort dropdown to search page - Add tabs to filter by object type (All, Projects, Registrations, Preprints, Files, Users) - Add dropdown to sort results by Relevance, Date modified/created ascending and descending - Change model names to reflect more library-analogy based names - Change how metadata properties are fetched from SHARE models * [No ticket] Update SHARE endpoints (CenterForOpenScience#1879) - Ticket: [No ticket] - Feature flag: n/a - Update SHAREAdapter to point to correct locations - Update SHAREAdapter parent class to point use config variable for share-url - Update SHAREAdapter parent class to point use api/v3 endpoints - Update search-related adapters to point to singularized endpoint names (e.g. api/v3/index-card-search**es** -> api/v3/index-card-search - Update mirage endpoints to reflect these changes * [ENG-4568] Componentize search page (CenterForOpenScience#1886) - Ticket: [ENG-4568] - Feature flag: n/a - Componentize search page for reuse in branded pages - Move logic and templating from search page route to `search-page` component - No logic for branding and default query-params yet in this PR * [ENG-4574] Preprint discover rewrite (CenterForOpenScience#1896) * add brand relationship to preprint provider model (CenterForOpenScience#1887) * Remove unused services from search controller * Use search-page component on preprint discover page * Modifiy branded-navbar for preprints * Error handling and theme resetting * Branded preprint discover part 1 * Branded preprint discover part 2 * Test prerpint discover page * Group CR feedback re: search-page component arguments * Fix test --------- Co-authored-by: Yuhuai Liu <yuhuai@cos.io> * [ENG-4573] Registry discover (CenterForOpenScience#1900) * preliminary * moar * some more * delete unused components * remove top-level aggregate registries discover route * remove top-level registries discover route cont. * remove unused action and variable on registries application route * remove aggregate registries discover page tests * fix tests * remove discover-test.ts * CR followup * [ENG-4574] Preprint discover fixes (CenterForOpenScience#1905) - Ticket: [ENG-4574] - Feature flag: n/a - Add appropriate page title to discover page - Add appropriate analytics scope to discover page - Make provider description now show html entities - Use `{{html-safe}}` when showing provider description - Add `providerTitle` in preprint-provider model - Most branded providers should show their name with their preprint word (e.g. AfricaRxiv Preprints, MarXiv Papers), except Thesis Commons - If it's OSF, we just show "OSF Preprints" - Add page-title and analytics scope using the new `providerTitle` * [ENG-4535] Search help feature (CenterForOpenScience#1907) - Ticket: [ENG-4535] - Feature flag: n/a - Add search help feature - Basically a re-implementation of CenterForOpenScience#1891 and CenterForOpenScience#1877 - Notable difference is moving the Popovers to the end of the file to avoid merge conflicts - Added EmberPopovers to the search-page component - Added getters to search-page component to fetch EmberPopover targets dynamically - Translations - Tests * [No Ticket] Change queryparam passed to SHARE when filtering by resourceType (CenterForOpenScience#1915) * change queryparam passed to SHARE when filtering by resourceType * add types * add some more types * update tests * [No ticket] Preprint branding rework (CenterForOpenScience#1913) - Ticket: [] - Feature flag: n/a - Only rely on `brand` relationship for setting preprint colors - Use `brand.primaryColor` for branded navbar background color - Add styling if the brand's primaryColor does not provide sufficient contrast with white text - Add special-case for BioHackrXiv to change navbar color to white (their primary color would be white, but that creates problems for `<Button>` behavior, so their primary is black instead) - Use `brand.heroBackgroundImage` for hero banner background, as well as advisory board section when @brianpilati implements that page. Currently just a solid color - Use `brand.navbarLogoImage` for navbar logo if `preprintProvider.assets.square_color_transparent` is not defined - Update `<Button>` component to detect primary color and use white/black text depending on color contrast * Preprints branding update (CenterForOpenScience#1922) - Ticket: [] - Feature flag: n/a - Remove possible failure point by not using preprintProvider.asset - Add special casing to address nutrixiv's navbar color https://osf.io/preprints/nutrixiv/ - Remove use of ThemeStyles from preprint (this set the navbar logo to use the preprintProvider.asset. square_color_transparent, when we want to just use the brand. topnavLogoImage going forward) - Add special case for nutrixiv to use a white background similar to biohackrxiv * Test prerpint discover page * Group CR feedback re: search-page component arguments * Added new preprints index to the new branch * Added translation strings * Fixed a rebase * Rebase fix * Removed the add-ons and moved search-help-modal to osf-components * Fixed a merge conflict * Fixed a few git merge conflicts * Added more logic to get the page to render * Added the taxonomy top list component and integrated it into the index page * Updates to the preprints template file to remove bootstrap * Fixed the css for the taxonomy-top-list * Removed an unnecessary import for analytics * Added more information for the providers * Added the advisory board attribute * Finished the html transformation for preprints * Fixed the routing to use a single template * Updates to remove unused variables and added branding * Fixed the css for the steering committee * Updates for comments from PR * Fixed some css and updated the mirage for global classes * Updates for branding * Added more styling for mobile * Added more information for preprints * Added more information for the taxomony * Added a branded footer for preprints * Fixed the preprint provider logic ... again * Fixed the branded header search * Fixed the page title logic * Removed useless test * Move preprint specific components to the app/preprints/-components * Added taxonomy tests * Added another test * Added another test * Added additional tests for the branded header * Added Branded footer tests * Pruned an unused providerModel from the branded-header * Added more tests * Added a test file * Added the initial template and attempt to have it compiled * Added the controller and the styles -- first pass * Added a router and continued to clean-up the controller * Removed chronos * Fixed an the computed and actions * Cleaned-up computed method * Removed unused route code * Added routing and a factory to mirage for preprints * Fixed the routing, mirage and prototyped the model is working * Initial steps to update the template * mirage updates * Updated users to have html link * Added logic to have the contributors displayed using the pre-build component * Updates for preprint details * Added more details for the preprint details page * Added information for the primaryFile * Added the ability to display a pdf from a local assets * Finished the abstract section * Added the license information * Added some miscellaneous logic for licenses * Added original date published * Added tags to the preprint detail page * Added citations and a lot of stuff that I have no idea about without Futa * Added the preprint doi * Added the supplemental material * Added the download option, with metrics * Initial work on the social icons * Added the plaudit widget * Added the final touches for mobile views * Initial pass for withdrawn preprints * Initial commit for the preprint-status-banner component * Additional refactors to bring the ts file up-to-date with latest ember * Added a current state icon method * Refactored all the constants to be typescript compatible * Appears the preprint status banner will now compile * Fixed mirage logic and some refactors * Added more styling and translations * Added a bunch of serializer, mirage and scenario logic * Added a bunch of mirage love * Finished all the conditional statements for the details page * Fixing scenarios with contributors * Finished adding all the preprint checks * refactored the doi to be a stand-alone component * Renamed doi to be preprint-doi * Added the preprint-license * Added the tombstone page * Added the preprint disciplines component * pruned some code * Converted the preprint-tag page * added the tombstone component * Added the abstract component and refactored the tombstone and detail page * Added the initial author-assertions * Added the preprint assertion link * Fixed the css for author assertions, coi and data * Finished author assertion for pre registration links * Removed unecessary comments * Fixed a few issues recommended by Futa after the mega-merge * Fixed pagination for branded preprint provider, added a provider without an image for a use case that eric is presenting * Removed all the `import config from ember-get-config` * Removed some comments * Removed some commentted out router code * Defined the data-test * Removed a bootstrap and eslint-ignore * Removed comments * Removed an unnecessary max-len * Removed comments * Removed comments * Fixed a length and added an enum * Added enums to a model * Renamed a method * Removed a stale file * Refactor the brandedProvider store call * Refactored a template file * Pruned translation strings * Removed a comment * Enum name change * Updated the inverse to be target on preprint files * removed the preprint-tag/component * Removed the tombstone component * Changed String to string * Changed String to string - Part II * Refactored a string to be an enum * endingWithdrawal to pendingWithdrawal * Removed the preprint-assertion-link component * Removed the branded-footer component * Refactored some comments and enums * Added a better IRI based filter * Pruned unused code * Fixed a translation string name * Removed unnecessary branded navbar params * Fixed a return enum from the api * Moved old unused code * Added the metric start date to the controller and environment * Fixed an overly aggressive find/replace and commented out code * Fixed the query on the taxonomy-top-list component * fixed the belongsTo relationship on a file * made the branded header search placeholder dynamic * Removed the abstractDoi from the preprint doi url * Removed the abstractDoi from the article * Fixed the branded footer * Preprint review action prototype * Updated the reviewActions for the Preprint model * change LinkTo element parameter * fix branded header tests * fix taxonomy-top-list tests * fix branded header test * Updated the abstract template to use expandable-preview and removed the component * set inverse to null * Fixed build issues * fix preprint routing * attempt * try this * Removed the bibiliographic stuff and added feature switches for M1 chips * Better fix for adapters * Revert "Better fix for adapters" This reverts commit da03639. * Revert "Removed the bibiliographic stuff and added feature switches for M1 chips" This reverts commit 4344e41. * Remvoed bibliographicContributors * Fixed the edit link * Added the fix for the search button * Fixed the routing for osf and branded providers * Fixed an issue with theme.reset * Removed button * pruning code * Use gray background for preprint detail * Show preprint as active service * Use config for donate link * Add different set of navbar links for preprints * Fixed the routing for /preprints/<guid> * Fix for Yuhuai * Update for Yuhuai * Fixed the plaudit env variables * Fixed the branded footer link for preprints (CenterForOpenScience#2059) * Added mobile logic to the author assetions * Fixed the styles for the status banner * Fixed the css will be non-biased * This did need a text-align: center * Allow provider-specfic default citation styles (CenterForOpenScience#2056) * Fix branded navbar colors for mobile (CenterForOpenScience#2060) * Fix branded navbar colors for mobile * Less whacky css rules * Fix link to my-preprints * Fixed a link * Fixed the logic for preprints with a coi of null * Preprint metadata (CenterForOpenScience#2065) * Avoid double-loading citation fixture * Add logic to add metadata to head for preprint detail * Updates to fix the text on the branded search page * Move favicon logic to parent route * Fix copy-pasta * Lint --------- Co-authored-by: futa-ikeda <51409893+futa-ikeda@users.noreply.github.com> Co-authored-by: Futa Ikeda <futa.ikeda@gmail.com> Co-authored-by: Brian Pilati <brianpilati@cos.io> Co-authored-by: Lord Business <113387478+bp-cos@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Summary of Changes
light-textclass, and just make white text the default.white-backgroundby just using.dark-textto indicate which text-color to useScreenshot(s)
Before photos in the notion card
Biohackrxiv (special-cased to use white background and black text on desktop)
Agrixiv (uses black text on desktop)
Other provider with white text
Side Effects
QA Notes