[ENG-4682] Mirage for addons #2062
Conversation
| scopes: [], | ||
| defaultRootFolder: faker.system.filePath, | ||
|
|
||
| configuringUser: belongsTo('internal-user'), |
There was a problem hiding this comment.
I do not recall doing this for my factories. Is that a thing that needs fixing? What does it do?
There was a problem hiding this comment.
So this was a misunderstanding of what these do. The association() helper can make it so that factories will automatically create a related model (e.g. server.create('draft-registration') will automagically create an initiator user). Whereas these belongsTo and hasMany helpers are used to define relationships in your data models (which we don't need to do, since we get this for free as we use ember-data)
|
Oh, actually, one more thing. Could you add to the dashboard scenario to put the box addon in to |
futa-ikeda
changed the title
| // Addon service | ||
| this.urlPrefix = addonServiceUrl; | ||
| this.namespace = '/v1'; | ||
| this.resource('external_storage_services', { only: ['index', 'show'] }); |
There was a problem hiding this comment.
Innnteresting. I didn't know this.resource was a thing.
There was a problem hiding this comment.
Yea, partway through writing some of these views, I realized it was a lot simpler than what I was doing 😅
I will add those requests/responses to the PR descriptions now! |
futa-ikeda
merged commit 739c9f7
into
CenterForOpenScience:feature/addon-services
Purpose
Summary of Changes
To-do
Screenshot(s)
external_storage_servicesinternal_resources/<guid>internal_users/<guid>internal_users/<guid>/authorized_storage_accountsauthorized_storage_accounts/<id>configured_storage_addons/<id>Side Effects
QA Notes