Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[No ticket] Fix reroute to not-found #2375

Merged
merged 1 commit into from
Nov 1, 2024
Merged

[No ticket] Fix reroute to not-found #2375

merged 1 commit into from
Nov 1, 2024

Conversation

futa-ikeda
Copy link
Contributor

@futa-ikeda futa-ikeda commented Nov 1, 2024 •
edited
Loading

  • Ticket: [No ticket]
  • Feature flag: n/a

Purpose

  • Fix when users are rerouted from the dashboard to the not-found page for whatever reason

Summary of Changes

  • use window.location.pathname for not-found param as this.router.get('currentURL') would often times be undefined leading to an error and a blank screen

Screenshot(s)

Side Effects

QA Notes

brianjgeiger
brianjgeiger approved these changes Nov 1, 2024
View reviewed changes
Copy link
Contributor

@brianjgeiger brianjgeiger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh. Interesting.

@futa-ikeda futa-ikeda merged commit b785d5c into CenterForOpenScience:feature/insti-dash-improv Nov 1, 2024
9 checks passed
@futa-ikeda futa-ikeda deleted the dashboard-rerouting branch November 1, 2024 19:00
@futa-ikeda futa-ikeda added this to the 24.09.0 milestone Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianjgeiger brianjgeiger brianjgeiger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
24.09.0
Development

Successfully merging this pull request may close these issues.
2 participants
@futa-ikeda @brianjgeiger