[ENG-6419] Share integration #2377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: Since this PR is blocking some initial QA efforts, I plan on changing some of the getters in |
brianjgeiger
approved these changes
Nov 5, 2024
Comment on lines
+23
to
+25
| export function getSingleOsfmapValue(osfmapObject: any, propertyPath: string[]) { | ||
| return iterOsfmapValues(osfmapObject, propertyPath).next().value; | ||
| } |
There was a problem hiding this comment.
What happens if you use this on something that's not a single value? Does it fail gracefully? Or does typescript help here?
There was a problem hiding this comment.
It should just get the first one, and if there's no @id or @value, it should just return undefined
futa-ikeda
merged commit a39b12c
into
CenterForOpenScience:feature/insti-dash-improv
9 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Summary of Changes
osfmap/jsonld.tswith utilities to make getting stuff from SHARE easier and more readableScreenshot(s)
Side Effects
QA Notes