Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[No ticket] Actually remove filters when removing them in the UI #2382

Conversation

futa-ikeda
Copy link
Contributor

@futa-ikeda futa-ikeda commented Nov 7, 2024

  • Ticket: [No ticket]
  • Feature flag: n/a

Purpose

  • Fix bug where removed filters were "remembered"

Summary of Changes

  • Change how we use the args.defaultQueryOptions param when building request query options
    • Previous method of initializing options was allowing us to directly add entries to defaultQueryOptions in line 53 (now line 55) when doing acc.cardSearchFilter[filter.propertyPathKey] = ...
    • New way of initializing options should no longer allow us to add new entries to defaultQueryOptions
    • Shallow copies are a doozy

Screenshot(s)

  • Before the fix: args.defaultQueryOptions object before and after this showing the newly added rights entry
    image
  • After the fix: args..defaultQueryOptions object remains the same
    image

Side Effects

QA Notes

@futa-ikeda futa-ikeda merged commit 10140b7 into CenterForOpenScience:feature/insti-dash-improv Nov 7, 2024
9 checks passed
@futa-ikeda futa-ikeda deleted the removing-filters branch November 7, 2024 21:40
@futa-ikeda futa-ikeda added this to the 24.09.0 milestone Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants