Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENG-6525] Fix partial feature support detection #2385

Merged
merged 1 commit into from
Nov 8, 2024
Merged

[ENG-6525] Fix partial feature support detection #2385

merged 1 commit into from
Nov 8, 2024

Conversation

futa-ikeda
Copy link
Contributor

@futa-ikeda futa-ikeda commented Nov 8, 2024 •
edited by jira bot
Loading

Purpose

  • Fix Terms widget to show partial feature support

Summary of Changes

  • Fix typo in logic to detect partial feature detection

Screenshot(s)

  • Before:
    image

  • After:
    image

Side Effects

QA Notes

brianjgeiger
brianjgeiger approved these changes Nov 8, 2024
View reviewed changes
Copy link
Contributor

@brianjgeiger brianjgeiger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not seeing a good way to make this less brittle. Looks good.

@brianjgeiger brianjgeiger merged commit 3013b64 into CenterForOpenScience:feature/addon-services Nov 8, 2024
9 checks passed
@futa-ikeda futa-ikeda deleted the tos-partial-functionality branch November 8, 2024 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianjgeiger brianjgeiger brianjgeiger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@futa-ikeda @brianjgeiger