[ENG-5024] feature/insti-dash-improv #2395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Ticket: [ENG-6074]
- Feature flag: n/a
## Purpose
- Rewrite existing institutional dashboard page to use OsfLayout and add tabs
## Summary of Changes
- Update app router to add new subroutes to institutional dashboard
- Add new component to handle layout of institutional dashboard subroutes (went this route instead of adding OsfLayout with an `{{outlet}}` to the parent route, as there may be some changes in layout based on subroutes)
- Move components to Summary and Users tab
- Trim any unneeded classes
- Update test
## Purpose Make sure the institutional dashboard can display all relevant information. ## Summary of Changes - add fields to user model - adds fields to mirage factories
- Ticket: [ENG-6078][ENG-6080] - Feature flag: n/a ## Purpose - Add new URL field to institution model for getting to archived reports - Add link to archived reports to the institutional dashboard pages ## Summary of Changes - Update institution model and update mirage - Update institution-dashboard-wrapper to include new link - Update how model hook works so we don't have to pass around a taskInstance - Update args and such for this - Remove controller - Glimmer-ize the institutional-user-list component
- Ticket: [] - Feature flag: n/a ## Purpose - Address some CR comments from prior PR #2296 ## Summary of Changes - Add a new arg `@fakeButton` to `OsfLink` to easily make a link look like a button (which maybe isn't a pattern we want to encourage, but at least now it's DRY when we do it 😬 ) - Update wording for hover text for reports - Have link open in a new window
…2300) - Ticket: [https://openscience.atlassian.net/browse/ENG-6116] - Feature flag: n/a ## Purpose This updates the old flaky institutional dashboard table with a new one that ## Summary of Changes - updates templates and css for new sorting arrow - adds new sorting arrow component (Product conversations supported not reusing SortButton) - adds tests to new componet - add to component code to allow toggling the arrow
- Ticket: [ENG-6181] - Feature flag: n/a ## Purpose - Update mirage view for trove index-card-search to return some more realistic results ## Summary of Changes - Replace placekittens with placecats - Remove hard-coded return object in mirage/views/search.ts - add a new factory-type object that creates resourceMetadata for index-cards of a given type
- Ticket: [https://openscience.atlassian.net/browse/ENG-6117] - Feature flag: n/a ## Purpose Add the ability to filter users by Orcid status, ensure filter works with sorting. ## Summary of Changes - adds slider inputs to user institutional dashboard tab - adds component code to make Orcid filters work - adds template code for layout.
…2320) - Ticket: [https://openscience.atlassian.net/browse/ENG-6194] - Feature flag: n/a ## Purpose Allow institutional admin to show/hide columns with department filter and sort arrows. ## Summary of Changes - Made template columns somewhat dynamic - made component recognize filtering columns - fixed up css to make presentable
…ForOpenScience/ember-osf-web into improve-mobile-styling-inst-dashboard * 'feature/insti-dash-improv' of https://github.com/CenterForOpenScience/ember-osf-web: Removed old tests Fixed some api issues Added a new test and removed an old one Added a new total count kpi # Conflicts: # translations/en-us.yml
…ForOpenScience/ember-osf-web into improve-mobile-styling-inst-dashboard * 'feature/insti-dash-improv' of https://github.com/CenterForOpenScience/ember-osf-web: Added a test with test-data elements Updates to add the project total # Conflicts: # translations/en-us.yml
…t-dashboard [ENG-6191] Improve Styling and Add Total Users Label
* Update getters in institution dashboard controllers * Update getters in search-result model
…tons [ENG-6280][ENG-6281] Add download dashboard buttons move archive link
- Ticket: [No ticket] - Feature flag: n/a ## Purpose - Update placeholder text when there is no data for a given column ## Summary of Changes - Use a simple `-` to denote missing values - Add placeholder text if no contributors are no longer affiliated for a project/registration/preprint
* Prevent first-page button from showing up on the first page * Reset page on sort or filter change
Pull Request Test Coverage Report for Build 11938601452Details
💛 - Coveralls |
* Show orcid in user list table * Update test
* Fix dropdown placement for mobile * a11y fix for items per page dropdown
brianjgeiger
approved these changes
Nov 20, 2024
Comment on lines
+14
to
+16
| /* | ||
| import InstitutionSummaryMetricModel from 'ember-osf-web/models/institution-summary-metric'; | ||
| */ |
There was a problem hiding this comment.
Is this needed anymore?
There was a problem hiding this comment.
Good catch, will address this in a follow-up PR after this is merged to prevent any frivolous Percy runs
Comment on lines
+85
to
+110
| /** | ||
| * I need to determine if this is going to be a feature or not | ||
| test('it renders the without data correctly', async function(this: EnginesIntlTestContext, assert) { | ||
| const data = Object({ | ||
| total: 0, | ||
| title: 'This is the title', | ||
| icon: 'building', | ||
| }); | ||
|
|
||
| this.set('data', data); | ||
|
|
||
|
|
||
| await render(hbs` | ||
| <Institutions::Dashboard::-Components::ChartKpiWrapper::ChartKpi | ||
| @data={{this.data}} | ||
| /> | ||
| `); | ||
|
|
||
| assert.dom('[data-test-kpi-title]') | ||
| .hasText('This is the title'); | ||
| assert.dom('[data-test-kpi-data]') | ||
| .hasText('No data for institution found.'); | ||
| assert.dom('[data-test-kpi-icon]') | ||
| .hasAttribute('data-icon', 'building'); | ||
| }); | ||
| */ |
There was a problem hiding this comment.
Have we determined if this is a feature or not?
There was a problem hiding this comment.
Seems this won't be needed, so will address this in a follow-up PR as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Summary of Changes
Screenshot(s)
Side Effects
QA Notes