Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENG-6401][ENG-6567] Mobile styling #2398

Merged
merged 2 commits into from
Nov 18, 2024
Merged

[ENG-6401][ENG-6567] Mobile styling #2398

merged 2 commits into from
Nov 18, 2024

Conversation

futa-ikeda
Copy link
Contributor

@futa-ikeda futa-ikeda commented Nov 15, 2024 •
edited
Loading

  • Ticket: [ENG-6401][ENG-6567]
  • Feature flag: n/a

Purpose

  • Avoid issue with weird text-wrap of tabs in mobile
  • Avoid issue with weird text-wrap of total users in mobile

Summary of Changes

  • Update CSS
  • Group buttons into divs of user-list topbar (best to view changes with whitespace off)

Screenshot(s)

  • Desktop before
    image

  • Desktop after (should be no changes)
    image

  • Mobile before
    image

  • Mobile after
    image

Side Effects

QA Notes

@futa-ikeda futa-ikeda changed the title Mobile styling [ENG-6401] Mobile styling Nov 15, 2024
@futa-ikeda futa-ikeda merged commit 46ea031 into CenterForOpenScience:feature/insti-dash-improv Nov 18, 2024
9 checks passed
@futa-ikeda futa-ikeda changed the title [ENG-6401] Mobile styling [ENG-6401][ENG-6567] Mobile styling Nov 18, 2024
@futa-ikeda futa-ikeda deleted the mobile-styling branch November 18, 2024 23:15
@futa-ikeda futa-ikeda added this to the 24.09.0 milestone Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianjgeiger brianjgeiger brianjgeiger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
24.09.0
Development

Successfully merging this pull request may close these issues.
2 participants
@futa-ikeda @brianjgeiger