Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENG-6585] Move boolean filters into group #2399

Merged
merged 1 commit into from
Nov 18, 2024
Merged

[ENG-6585] Move boolean filters into group #2399

merged 1 commit into from
Nov 18, 2024

Conversation

futa-ikeda
Copy link
Contributor

@futa-ikeda futa-ikeda commented Nov 18, 2024 •
edited by jira bot
Loading

Purpose

  • Combine boolean filters into one group to match filtering behavior of search page

Summary of Changes

  • Create a new boolean-filter group on institutional dashboard filter list

Screenshot(s)

  • Before (bug where some filter value names may be blank):
    image

  • After:
    image

Side Effects

QA Notes

aaxelb
aaxelb approved these changes Nov 18, 2024
View reviewed changes
Copy link
Contributor

@aaxelb aaxelb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay for reusable code!

@futa-ikeda futa-ikeda merged commit fe98821 into CenterForOpenScience:feature/insti-dash-improv Nov 18, 2024
9 checks passed
@futa-ikeda futa-ikeda deleted the boolean-filters branch November 18, 2024 22:26
@futa-ikeda futa-ikeda added this to the 24.09.0 milestone Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaxelb aaxelb aaxelb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
24.09.0
Development

Successfully merging this pull request may close these issues.
2 participants
@futa-ikeda @aaxelb