Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show orcid in user list table #2403

Conversation

futa-ikeda
Copy link
Contributor

  • Ticket: []
  • Feature flag: n/a

Purpose

  • Show ORCID info in user list table

Summary of Changes

  • Add new column type in user list

Screenshot(s)

image

Side Effects

QA Notes

@tracked hasOrcid = false;
@tracked totalUsers = 0;

orcidUrlPrefix = 'https://orcid.org/'; // Move to config?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that's something that's likely to need to change per environment, so probably doesn't need to be configurable.

@brianjgeiger
Copy link
Contributor

169) [Chrome 131.0] Exam Partition 4 - Integration | routes | institutions | dashboard | -components | institutional-users-list: it renders and paginates 8 default columns
     8 default headers

     expected: 'Element [data-test-header] exists 8 times'
       actual: 'Element [data-test-header] exists 9 times'

@futa-ikeda futa-ikeda merged commit 54b4eb9 into CenterForOpenScience:feature/insti-dash-improv Nov 19, 2024
9 checks passed
@futa-ikeda futa-ikeda deleted the show-orcids branch November 19, 2024 19:16
@futa-ikeda futa-ikeda added this to the 24.09.0 milestone Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants