Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENG-6567][ENG-6598] Fix dropdown placement for mobile #2408

Conversation

futa-ikeda
Copy link
Contributor

@futa-ikeda futa-ikeda commented Nov 20, 2024

Purpose

  • Fix dropdown placement for mobile view
  • Fix a11y best practice issue where dropdown isn't properly labeled

Summary of Changes

  • Remove unneeded CSS property
  • Use an explicit <label> element for "Items per page" dropdown

Screenshot(s)

  • Before:
    image
    image

  • After:
    image
    image

Side Effects

QA Notes

@futa-ikeda futa-ikeda changed the title [ENG-6567] Fix dropdown placement for mobile [ENG-6567][ENG-6598] Fix dropdown placement for mobile Nov 20, 2024
@futa-ikeda futa-ikeda merged commit 684c877 into CenterForOpenScience:feature/insti-dash-improv Nov 20, 2024
9 checks passed
@futa-ikeda futa-ikeda deleted the mobile-dropdown-placement branch November 20, 2024 17:26
@futa-ikeda futa-ikeda added this to the 24.09.0 milestone Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants