[ENG-6669][WIP] Institutional Access project Request Modal #2433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Johnetordoff
force-pushed
the
institutional-access-project-request-modal
branch
from
fa41842 to
e80b7f9
Compare
Johnetordoff
commented
Dec 18, 2024
| @@ -47,32 +49,40 @@ export default class InstitutionalObjectListContributorsField extends Component< | |||
| return prioritizedAttributions.slice(0, 2).map(attribution => { | |||
| const contributor = getContributorById(contributors, getSingleOsfmapValue(attribution, ['agent'])); | |||
| const roleIri: AttributionRoleIris = getSingleOsfmapValue(attribution, ['hadRole']); | |||
|
|
|||
| const regex = /([^?#]+)$/; // Regex to extract the final part after the last slash | |||
| const contributorId = contributor?.['@id']?.match(regex)?.[1] || ''; | |||
There was a problem hiding this comment.
Is there a better way to get user guid?
Johnetordoff
force-pushed
the
institutional-access-project-request-modal
branch
from
e80b7f9 to
5a7fe94
Compare
Johnetordoff
changed the title
…terForOpenScience/ember-osf-web into institutional-access-project-request-modal * 'feature/institutional-access' of https://github.com/CenterForOpenScience/ember-osf-web: use proper Ember input tags, remove extra close modal command make message types an enum update language and fix modal closing bug. update to fit Product language and styling add checkboxes for reply-to and ccing Add type annotations for belongs to update text area for Ember type area update sendMessage to task fix label for message box add aira-label. fix en-us typo Add user messaging modal to user's tab on institutional dashboard
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Allows institutional admins to request access to projects from the institutional dashboard projects tab. Also allows them to message thier institutional users.
Summary of Changes
Send MessageandRequest AccesstabsScreenshot(s)
Request access disabled behavior
Screen.Recording.2024-12-17.at.10.06.33.AM.mov
Side Effects
QA Notes