Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENG-6744] FE: Contributors can "configure" others' addons #2438

Open
wants to merge 5 commits into
base: feature/addon-services
Choose a base branch
from

Conversation

opaduchak
Copy link

@opaduchak opaduchak commented Dec 26, 2024

  • Ticket: ENG-6744
  • Feature flag: gravy_waffle

Purpose

Summary of Changes

  • fixed configure button displayed when user won't be able to configure addon
  • fixed user and resource reference reuest swarm

Screenshot(s)

image

Side Effects

QA Notes

… addon, fixed user and resource reference reuest swarm
@opaduchak opaduchak changed the title [ENG-6744] [ENG-6744] FE: Contributors can "configure" others' addons Dec 26, 2024
Copy link
Contributor

@adlius adlius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall it looks really good. I have got one question. The ticket requires that the admin should be able to delete the addons that others have configured. So that means in the page after the "Configure" button is clicked, the pencil button should not be there. Does this PR remove the pencil buttons for admins when they try to configure addons that others have configured?
Screenshot from 2024-12-27 10-45-11

Copy link
Contributor

@futa-ikeda futa-ikeda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the screenshot in this PR is from the perspective of someone who isn't a project admin, but is the owner of the connected Box and Google Drive account, correct?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants