Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: make datasetId optional for experiments #46

Merged
merged 5 commits into from
Jul 26, 2024
Merged

feat: make datasetId optional for experiments #46

merged 5 commits into from
Jul 26, 2024

Conversation

willydouhard
Copy link
Contributor

No description provided.

@linear Linear
Copy link

linear bot commented Jul 24, 2024

ENG-1669 Experiments features

Description

We want specific experiments features:

  • from a dataset jump to the list of experiments (experiments table filtered on that dataset, which corresponds to the leaderboard for that dataset)

image.png

  • order experiments on score value descending
  • on experiments comparison, specify what's before/after in the column headers to better understanding what's diff-ed.

@willydouhard
Copy link
Contributor Author

CI fails because this PR https://github.com/Chainlit/chainlit-cloud/pull/817 is not merged on staging (making dataset id optional)

@willydouhard willydouhard force-pushed the willy/eng-1669-experiments-features branch from 9888db1 to a094b2f Compare July 24, 2024 10:05
Dam-Buty
Dam-Buty approved these changes Jul 25, 2024
View reviewed changes
Copy link
Contributor

@Dam-Buty Dam-Buty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just the one forgotten line, feel free to merge when the relevant commits are on staging & E2E pass

src/types.ts Outdated Show resolved Hide resolved
@Dam-Buty Dam-Buty merged commit f5ddc48 into main Jul 26, 2024
2 checks passed
@desaxce desaxce deleted the willy/eng-1669-experiments-features branch July 29, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dam-Buty Dam-Buty Dam-Buty approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@willydouhard @Dam-Buty