Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused jdmath functions? #74

Open
hamogu opened this issue Nov 23, 2023 · 1 comment
Open

Remove unused jdmath functions? #74

hamogu opened this issue Nov 23, 2023 · 1 comment

Comments

@hamogu
Copy link
Member

hamogu commented Nov 23, 2023

jdmath contains some functions that are not used in marx. Is is worthwhile to remove them to reduce maintenance?
Below is a list of functions as I find them, but a systematic review may reveal more:

  • hist.c: None of the histogram functions are used, except in the demo program to demo rebinning
@hamogu
Copy link
Member Author

hamogu commented Nov 27, 2023

Interpolation is defined twice, once for floats and once for doubles in finterpo.c and dinterpo.c. Any fixes to one of those files should probably be applied to both. hist.c shows an approach of using the preprocessor to use the same code for two different data types; on the one hand that's less duplication, but it's also harder to read.

@hamogu hamogu changed the title Remove unsued jdmath functions? Remove unused jdmath functions? Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant