Remove EA_MIRROR #77
Merged
Remove EA_MIRROR #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamogu
force-pushed
the
remove_eamirror
branch
from
30aff34
to
fd30be3
Compare
For a long time, the docs have said: > This simple model is of historical interest only and is no longer accurate or supported. This option should not be selected. This PR removes the EA mirror model. It reduces maintenance (though small, it's not zero) and I find that any option that exists will be used by a user at some point and then they get inaccurate results. It's safer to remove an option that expressively should not be used any longer. closes Chandra-MARX#75
hamogu
force-pushed
the
remove_eamirror
branch
from
fd30be3
to
cc42ed1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a long time, the docs have said:
This PR removes the EA mirror model.
It reduces maintenance (though small, it's not zero) and I find that any option that exists will be used by a user at some point and then they get inaccurate results. It's safer to remove an option that expressively should not be used any longer.
closes #75